Remove Safebrowsing Rappor support

Remove Safebrowsing Rappor support

BUG=696797
Review-Url: https://codereview.chromium.org/2718253002
Cr-Commit-Position: refs/heads/master@{#457220}
Committed: https://chromium.googlesource.com/chromium/src/+/0036d9b08e86648bdfae7429909b9696695c7107

[Steven Holte, 2017-02-28 00:08:16]

Description was changed from

==========
Remove Safebrowsing Rappor support

BUG=
==========

to

==========
Remove Safebrowsing Rappor support

BUG=696797
==========

[Steven Holte, 2017-02-28 00:08:16]

holte@chromium.org changed reviewers:
+ asvitkine@chromium.org, lpromero@chromium.org

[Steven Holte, 2017-02-28 00:09:38]

The CQ bit was checked by holte@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 00:10:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:21:44]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Steven Holte, 2017-02-28 00:35:57]

The CQ bit was checked by holte@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 00:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:46:55]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Steven Holte, 2017-02-28 22:27:42]

The CQ bit was checked by holte@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 22:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:03:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Steven Holte, 2017-03-08 00:06:38]

The CQ bit was checked by holte@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 00:07:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:51:10]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-03-13 22:50:15]

ios lgtm

[Alexei Svitkine (slow), 2017-03-14 21:58:17]

https://codereview.chromium.org/2718253002/diff/60001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_metrics_services_manager_client.h (right):

https://codereview.chromium.org/2718253002/diff/60001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_services_manager_client.h:14: #include
"chrome/browser/safe_browsing/safe_browsing_service.h"
Remove?

https://codereview.chromium.org/2718253002/diff/60001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_services_manager_client.h:98:
sb_state_subscription_;
Remove?

[Steven Holte, 2017-03-15 20:06:30]

https://codereview.chromium.org/2718253002/diff/60001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_metrics_services_manager_client.h (right):

https://codereview.chromium.org/2718253002/diff/60001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_services_manager_client.h:14: #include
"chrome/browser/safe_browsing/safe_browsing_service.h"
On 2017/03/14 21:58:17, Alexei Svitkine (very slow) wrote:
> Remove?

Done.

https://codereview.chromium.org/2718253002/diff/60001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_services_manager_client.h:98:
sb_state_subscription_;
On 2017/03/14 21:58:17, Alexei Svitkine (very slow) wrote:
> Remove?

Done.

[Alexei Svitkine (slow), 2017-03-15 20:11:34]

lgtm

[Steven Holte, 2017-03-15 20:25:08]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-03-15 20:25:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2718253002/#ps80001
(title: "Remove sb include")

[commit-bot: I haz the power, 2017-03-15 20:25:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 21:49:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489609508972290,
"parent_rev": "f3c462c3963cdd0a362bf87eddc97d40aac4c638", "commit_rev":
"0036d9b08e86648bdfae7429909b9696695c7107"}

[commit-bot: I haz the power, 2017-03-15 21:50:32]

Description was changed from

==========
Remove Safebrowsing Rappor support

BUG=696797
==========

to

==========
Remove Safebrowsing Rappor support

BUG=696797

Review-Url: https://codereview.chromium.org/2718253002
Cr-Commit-Position: refs/heads/master@{#457220}
Committed:
https://chromium.googlesource.com/chromium/src/+/0036d9b08e86648bdfae7429909b...
==========

[commit-bot: I haz the power, 2017-03-15 21:50:34]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0036d9b08e86648bdfae7429909b...