Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: components/rappor/rappor_service_impl.h

Issue 2718253002: Remove Safebrowsing Rappor support (Closed)
Patch Set: Remove sb include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/rappor/public/rappor_parameters.h ('k') | components/rappor/rappor_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rappor/rappor_service_impl.h
diff --git a/components/rappor/rappor_service_impl.h b/components/rappor/rappor_service_impl.h
index 625ff9d06d23aed6f3a58d691b3fa07c476c112f..540eb44a0d295b76ef53de05cfee25925f37fc8b 100644
--- a/components/rappor/rappor_service_impl.h
+++ b/components/rappor/rappor_service_impl.h
@@ -56,12 +56,10 @@ class RapporServiceImpl : public RapporService {
// Updates the settings for metric recording and uploading.
// The RapporServiceImpl must be initialized before this method is called.
- // |recording_groups| should be set of flags, e.g.
- // UMA_RECORDING_GROUP | SAFEBROWSING_RECORDING_GROUP
- // If it contains any enabled groups, periodic reports will be
- // generated and queued for upload.
+ // If |may_record| is true, data will be recorded and periodic reports will
+ // be generated and queued for upload.
// If |may_upload| is true, reports will be uploaded from the queue.
- void Update(int recording_groups, bool may_upload);
+ void Update(bool may_record, bool may_upload);
// Constructs a Sample object for the caller to record fields in.
std::unique_ptr<Sample> CreateSample(RapporType) override;
@@ -154,9 +152,8 @@ class RapporServiceImpl : public RapporService {
// A private LogUploader instance for sending reports to the server.
std::unique_ptr<LogUploaderInterface> uploader_;
- // The set of recording groups that metrics are being recorded, e.g.
- // UMA_RECORDING_GROUP | SAFEBROWSING_RECORDING_GROUP
- int recording_groups_;
+ // Whether new data can be recorded.
+ bool recording_enabled_;
// We keep all registered metrics in a map, from name to metric.
std::map<std::string, std::unique_ptr<RapporMetric>> metrics_map_;
« no previous file with comments | « components/rappor/public/rappor_parameters.h ('k') | components/rappor/rappor_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698