Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: components/rappor/public/rappor_parameters.h

Issue 2718253002: Remove Safebrowsing Rappor support (Closed)
Patch Set: Remove sb include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/rappor/BUILD.gn ('k') | components/rappor/rappor_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rappor/public/rappor_parameters.h
diff --git a/components/rappor/public/rappor_parameters.h b/components/rappor/public/rappor_parameters.h
index 0497615fba742af094532ebd33da4613fff99f53..279d09ec3b4f7da3d6c0887b67883f5a5ba113e4 100644
--- a/components/rappor/public/rappor_parameters.h
+++ b/components/rappor/public/rappor_parameters.h
@@ -23,20 +23,14 @@ enum NoiseLevel {
enum RapporType {
// Generic metrics from UMA opt-in users.
UMA_RAPPOR_TYPE = 0,
- // Generic metrics for SafeBrowsing users. Deprecated, replaced by
- // LOW_FREQUENCY_SAFEBROWSING_RAPPOR_TYPE.
- SAFEBROWSING_RAPPOR_TYPE,
// Deprecated: Use UMA_RAPPOR_TYPE for new metrics
ETLD_PLUS_ONE_RAPPOR_TYPE,
// Type for low-frequency metrics from UMA opt-in users.
LOW_FREQUENCY_UMA_RAPPOR_TYPE,
- // Type for low-frequency metrics from SafeBrowsing users.
- LOW_FREQUENCY_SAFEBROWSING_RAPPOR_TYPE,
// Type for low-frequency metrics from UMA opt-in users. Do not use for new
// metrics.
LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
NUM_RAPPOR_TYPES,
- COARSE_RAPPOR_TYPE = SAFEBROWSING_RAPPOR_TYPE,
};
enum Probability {
@@ -52,8 +46,6 @@ enum Probability {
enum RecordingGroup {
// Metrics for UMA users.
UMA_RAPPOR_GROUP = 1 << 0,
- // Metrics related to SafeBrowsing, for SafeBrowsing users.
- SAFEBROWSING_RAPPOR_GROUP = 1 << 1,
};
// An object describing noise probabilities for a noise level
@@ -134,14 +126,6 @@ const RapporParameters kRapporParametersForType[NUM_RAPPOR_TYPES] = {
rappor::NORMAL_NOISE /* Noise level */,
UMA_RAPPOR_GROUP /* Recording group */
},
- // SAFEBROWSING_RAPPOR_TYPE
- {
- 128 /* Num cohorts */,
- 1 /* Bloom filter size bytes */,
- 2 /* Bloom filter hash count */,
- rappor::NORMAL_NOISE /* Noise level */,
- SAFEBROWSING_RAPPOR_GROUP /* Recording group */
- },
// ETLD_PLUS_ONE_RAPPOR_TYPE
{
128 /* Num cohorts */,
@@ -158,14 +142,6 @@ const RapporParameters kRapporParametersForType[NUM_RAPPOR_TYPES] = {
rappor::SPARSE_NOISE /* Noise level */,
UMA_RAPPOR_GROUP /* Recording group */
},
- // LOW_FREQUENCY_SAFEBROWSING_RAPPOR_TYPE
- {
- 128 /* Num cohorts */,
- 1 /* Bloom filter size bytes */,
- 2 /* Bloom filter hash count */,
- rappor::SPARSE_NOISE /* Noise level */,
- SAFEBROWSING_RAPPOR_GROUP /* Recording group */
- },
// LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE
{
128 /* Num cohorts */,
« no previous file with comments | « components/rappor/BUILD.gn ('k') | components/rappor/rappor_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698