Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/rappor/rappor_service_impl.cc

Issue 2718253002: Remove Safebrowsing Rappor support (Closed)
Patch Set: Remove sb include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/rappor/rappor_service_impl.h ('k') | components/rappor/rappor_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rappor/rappor_service_impl.cc
diff --git a/components/rappor/rappor_service_impl.cc b/components/rappor/rappor_service_impl.cc
index 19bfc67f3e6eabc65bbc01307cf7ae4873924f08..d0c85f8c7a2ade8ae10baed59580e2130acf1dca 100644
--- a/components/rappor/rappor_service_impl.cc
+++ b/components/rappor/rappor_service_impl.cc
@@ -59,7 +59,7 @@ RapporServiceImpl::RapporServiceImpl(
daily_event_(pref_service,
prefs::kRapporLastDailySample,
kRapporDailyEventHistogram),
- recording_groups_(0) {}
+ recording_enabled_(false) {}
RapporServiceImpl::~RapporServiceImpl() {}
@@ -84,27 +84,22 @@ void RapporServiceImpl::Initialize(
internal::LoadCohort(pref_service_), internal::LoadSecret(pref_service_));
}
-void RapporServiceImpl::Update(int recording_groups, bool may_upload) {
+void RapporServiceImpl::Update(bool may_record, bool may_upload) {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(IsInitialized());
- if (recording_groups_ != recording_groups) {
- if (recording_groups == 0) {
+ if (recording_enabled_ != may_record) {
+ recording_enabled_ = may_record;
+ if (!may_record) {
DVLOG(1) << "Rappor service stopped because all groups were disabled.";
- recording_groups_ = 0;
CancelNextLogRotation();
- } else if (recording_groups_ == 0) {
- DVLOG(1) << "RapporServiceImpl started for groups: " << recording_groups;
- recording_groups_ = recording_groups;
+ } else {
+ DVLOG(1) << "RapporServiceImpl started.";
ScheduleNextLogRotation(
base::TimeDelta::FromSeconds(kInitialLogIntervalSeconds));
- } else {
- DVLOG(1) << "RapporServiceImpl recording_groups changed:"
- << recording_groups;
- recording_groups_ = recording_groups;
}
}
- DVLOG(1) << "RapporServiceImpl recording_groups=" << recording_groups_
+ DVLOG(1) << "RapporServiceImpl recording_groups=" << recording_enabled_
<< " may_upload=" << may_upload;
if (may_upload) {
uploader_->Start();
@@ -191,9 +186,8 @@ bool RapporServiceImpl::RecordingAllowed(const RapporParameters& parameters) {
return false;
}
// Skip this metric if its recording_group is not enabled.
- if (!(recording_groups_ & parameters.recording_group)) {
- DVLOG(2) << "Metric not logged due to recording_group " << recording_groups_
- << " < " << parameters.recording_group;
+ if (!recording_enabled_) {
+ DVLOG(2) << "Metric not logged due to recording_enabled_ = false.";
return false;
}
return true;
« no previous file with comments | « components/rappor/rappor_service_impl.h ('k') | components/rappor/rappor_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698