Use install_static::GetAppGuid in place of BrowserDistribution and AppRegistrationData.

Use install_static::GetAppGuid in place of BrowserDistribution and AppRegistrationData.

BUG=373987
R=huangs@chromium.org

Review-Url: https://codereview.chromium.org/2718063002
Cr-Commit-Position: refs/heads/master@{#453330}
Committed: https://chromium.googlesource.com/chromium/src/+/4474dad01085cdbaf59267e35179b0a4076c558d

[grt (UTC plus 2), 2017-02-27 13:48:45]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 13:48:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-02-27 13:49:15]

Hi Sam. This is one more small step toward using the new install_static data
everywhere. Thanks for taking a look.

[commit-bot: I haz the power, 2017-02-27 14:22:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 14:22:09]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[grt (UTC plus 2), 2017-02-27 14:39:29]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 14:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[huangs, 2017-02-27 16:02:41]

On 2017/02/27 13:49:15, grt (UTC plus 1) wrote:
> Hi Sam. This is one more small step toward using the new install_static data
> everywhere. Thanks for taking a look.

LGTM with a few NITs.

[commit-bot: I haz the power, 2017-02-27 16:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:12:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[huangs, 2017-02-27 16:15:15]

Oops should publish the NITs.

https://codereview.chromium.org/2718063002/diff/20001/chrome/install_static/i...
File chrome/install_static/install_util_unittest.cc (right):

https://codereview.chromium.org/2718063002/diff/20001/chrome/install_static/i...
chrome/install_static/install_util_unittest.cc:355:
L"{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20}",  // Google Chrome SxS (canary).
NIT: Capitalize "Canary"?

I find it odd that the two GUIDs have different capitalization -- but probably
best to maintain status quo (this includes case-sensitive string comparison
below)...

https://codereview.chromium.org/2718063002/diff/20001/chrome/install_static/i...
chrome/install_static/install_util_unittest.cc:361: FAIL() << "Not
implemented.";
So Chromium test will fail?  And if the parameterized test is skipped by  for
Chromium, then #if defined(GOOGLE_CHROME_BUILD) should wrap at a different
level?

[grt (UTC plus 2), 2017-02-27 20:04:48]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-02-27 20:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from huangs@chromium.org
Link to the patchset: https://codereview.chromium.org/2718063002/#ps40001
(title: "huangs feedback plus Chromium test fix")

[commit-bot: I haz the power, 2017-02-27 20:05:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 20:15:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2017-02-27 20:53:01]

grt@chromium.org changed reviewers:
+ pkasting@chromium.org

[grt (UTC plus 2), 2017-02-27 20:53:01]

+PK for chrome/browser/google OWNERS stamp. Please take the liberty of checking
the CQ box if you approve. Thanks.

https://codereview.chromium.org/2718063002/diff/20001/chrome/install_static/i...
File chrome/install_static/install_util_unittest.cc (right):

https://codereview.chromium.org/2718063002/diff/20001/chrome/install_static/i...
chrome/install_static/install_util_unittest.cc:355:
L"{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20}",  // Google Chrome SxS (canary).
On 2017/02/27 16:15:14, huangs wrote:
> NIT: Capitalize "Canary"?

Done.

> I find it odd that the two GUIDs have different capitalization -- but probably
> best to maintain status quo (this includes case-sensitive string comparison
> below)...

Yeah, I find it odd, too. I'll make it all caps here and make the expectation
case-insensitive. This makes sense in any case since the Windows registry is
case-insensitive (it's also insensitive about many other things, but that's
between me and my analyst).

https://codereview.chromium.org/2718063002/diff/20001/chrome/install_static/i...
chrome/install_static/install_util_unittest.cc:361: FAIL() << "Not
implemented.";
On 2017/02/27 16:15:14, huangs wrote:
> So Chromium test will fail?  And if the parameterized test is skipped by  for
> Chromium, then #if defined(GOOGLE_CHROME_BUILD) should wrap at a different
> level?

I'd meant for the test to exit just after line 349 in the branch up there. The
idea here is for forks to end up with a test failure here so that they know
where to add their own magic app guids.

[Peter Kasting, 2017-02-27 20:54:26]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2017-02-27 20:54:27]

lgtm

[commit-bot: I haz the power, 2017-02-27 20:55:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 21:00:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488228866457730,
"parent_rev": "7c7c851f2d26771af4d3debf4e7aaa54d1c23353", "commit_rev":
"4474dad01085cdbaf59267e35179b0a4076c558d"}

[commit-bot: I haz the power, 2017-02-27 21:01:31]

Description was changed from

==========
Use install_static::GetAppGuid in place of BrowserDistribution and
AppRegistrationData.

BUG=373987
R=huangs@chromium.org
==========

to

==========
Use install_static::GetAppGuid in place of BrowserDistribution and
AppRegistrationData.

BUG=373987
R=huangs@chromium.org

Review-Url: https://codereview.chromium.org/2718063002
Cr-Commit-Position: refs/heads/master@{#453330}
Committed:
https://chromium.googlesource.com/chromium/src/+/4474dad01085cdbaf59267e35179...
==========

[commit-bot: I haz the power, 2017-02-27 21:01:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4474dad01085cdbaf59267e35179...