Use install_static::GetAppGuid in place of BrowserDistribution and AppRegistrationData.

chrome/installer/util/google_update_settings_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/google_update_settings.h"
 
 #include <windows.h>
 #include <shlwapi.h>  // For SHDeleteKey.
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/base_paths.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/scoped_path_override.h"
 #include "base/test/test_reg_util_win.h"
 #include "base/win/registry.h"
 #include "base/win/win_util.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/install_static/install_util.h"
 #include "chrome/install_static/test/scoped_install_details.h"
 #include "chrome/installer/util/app_registration_data.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/channel_info.h"
 #include "chrome/installer/util/fake_installation_state.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/helper.h"
 #include "chrome/installer/util/util_constants.h"
 #include "chrome/installer/util/work_item_list.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 666 matching lines @@
                    KEY_SET_VALUE).WriteValue(app_policy_value.c_str(),
                                              static_cast<DWORD>(4)));
   is_overridden = true;
   EXPECT_EQ(GoogleUpdateSettings::UPDATES_DISABLED,
             GoogleUpdateSettings::GetAppUpdatePolicy(kTestProductGuid,
                                                      &is_overridden));
   EXPECT_FALSE(is_overridden);
 }
 
 TEST_F(GoogleUpdateSettingsTest, PerAppUpdatesDisabledByPolicy) {
-  BrowserDistribution* dist = BrowserDistribution::GetDistribution();
-  EXPECT_TRUE(
-      SetUpdatePolicyForAppGuid(dist->GetAppGuid(),
-                                GoogleUpdateSettings::UPDATES_DISABLED));
+  const wchar_t* app_guid = install_static::GetAppGuid();
+  EXPECT_TRUE(SetUpdatePolicyForAppGuid(
+      app_guid, GoogleUpdateSettings::UPDATES_DISABLED));
   bool is_overridden = false;
   GoogleUpdateSettings::UpdatePolicy update_policy =
-      GoogleUpdateSettings::GetAppUpdatePolicy(dist->GetAppGuid(),
-                                               &is_overridden);
+      GoogleUpdateSettings::GetAppUpdatePolicy(app_guid, &is_overridden);
   EXPECT_TRUE(is_overridden);
   EXPECT_EQ(GoogleUpdateSettings::UPDATES_DISABLED, update_policy);
   EXPECT_FALSE(GoogleUpdateSettings::AreAutoupdatesEnabled());
 
   EXPECT_TRUE(GoogleUpdateSettings::ReenableAutoupdates());
-  update_policy = GoogleUpdateSettings::GetAppUpdatePolicy(dist->GetAppGuid(),
-                                                           &is_overridden);
+  update_policy =
+      GoogleUpdateSettings::GetAppUpdatePolicy(app_guid, &is_overridden);
   // Should still have a policy but now that policy should explicitly enable
   // updates.
   EXPECT_TRUE(is_overridden);
   EXPECT_EQ(GoogleUpdateSettings::AUTOMATIC_UPDATES, update_policy);
   EXPECT_TRUE(GoogleUpdateSettings::AreAutoupdatesEnabled());
 }
 
 TEST_F(GoogleUpdateSettingsTest, PerAppUpdatesEnabledWithGlobalDisabled) {
   // Disable updates globally but enable them for Chrome (the app-specific
   // setting should take precedence).
-  BrowserDistribution* dist = BrowserDistribution::GetDistribution();
-  EXPECT_TRUE(
-      SetUpdatePolicyForAppGuid(dist->GetAppGuid(),
-                                GoogleUpdateSettings::AUTOMATIC_UPDATES));
+  const wchar_t* app_guid = install_static::GetAppGuid();
+  EXPECT_TRUE(SetUpdatePolicyForAppGuid(
+      app_guid, GoogleUpdateSettings::AUTOMATIC_UPDATES));
   EXPECT_TRUE(SetGlobalUpdatePolicy(GoogleUpdateSettings::UPDATES_DISABLED));
 
   // Make sure we read this as still having updates enabled.
   EXPECT_TRUE(GoogleUpdateSettings::AreAutoupdatesEnabled());
 
   // Make sure that the reset action returns true and is a no-op.
   EXPECT_TRUE(GoogleUpdateSettings::ReenableAutoupdates());
   EXPECT_EQ(GoogleUpdateSettings::AUTOMATIC_UPDATES,
-            GetUpdatePolicyForAppGuid(dist->GetAppGuid()));
+            GetUpdatePolicyForAppGuid(app_guid));
   EXPECT_EQ(GoogleUpdateSettings::UPDATES_DISABLED, GetGlobalUpdatePolicy());
 }
 
 TEST_F(GoogleUpdateSettingsTest, GlobalUpdatesDisabledByPolicy) {
-  BrowserDistribution* dist = BrowserDistribution::GetDistribution();
+  const wchar_t* app_guid = install_static::GetAppGuid();
   EXPECT_TRUE(SetGlobalUpdatePolicy(GoogleUpdateSettings::UPDATES_DISABLED));
   bool is_overridden = false;
 
   // The contract for GetAppUpdatePolicy states that |is_overridden| should be
   // set to false when updates are disabled on a non-app-specific basis.
   GoogleUpdateSettings::UpdatePolicy update_policy =
-      GoogleUpdateSettings::GetAppUpdatePolicy(dist->GetAppGuid(),
-                                               &is_overridden);
+      GoogleUpdateSettings::GetAppUpdatePolicy(app_guid, &is_overridden);
   EXPECT_FALSE(is_overridden);
   EXPECT_EQ(GoogleUpdateSettings::UPDATES_DISABLED, update_policy);
   EXPECT_FALSE(GoogleUpdateSettings::AreAutoupdatesEnabled());
 
   EXPECT_TRUE(GoogleUpdateSettings::ReenableAutoupdates());
-  update_policy = GoogleUpdateSettings::GetAppUpdatePolicy(dist->GetAppGuid(),
-                                                           &is_overridden);
+  update_policy =
+      GoogleUpdateSettings::GetAppUpdatePolicy(app_guid, &is_overridden);
   // Policy should now be to enable updates, |is_overridden| should still be
   // false.
   EXPECT_FALSE(is_overridden);
   EXPECT_EQ(GoogleUpdateSettings::AUTOMATIC_UPDATES, update_policy);
   EXPECT_TRUE(GoogleUpdateSettings::AreAutoupdatesEnabled());
 }
 
 TEST_F(GoogleUpdateSettingsTest, UpdatesDisabledByTimeout) {
   // Disable updates altogether.
   EXPECT_TRUE(SetUpdateTimeoutOverride(0));
@@ skipping 405 matching lines @@
                                  StatsState::TRUE_SETTING),
                       StatsState(StatsState::kSystemLevel,
                                  StatsState::TRUE_SETTING,
                                  StatsState::NO_SETTING),
                       StatsState(StatsState::kSystemLevel,
                                  StatsState::TRUE_SETTING,
                                  StatsState::FALSE_SETTING),
                       StatsState(StatsState::kSystemLevel,
                                  StatsState::TRUE_SETTING,
                                  StatsState::TRUE_SETTING)));