Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 2718063002: Use install_static::GetAppGuid in place of BrowserDistribution and AppRegistrationData. (Closed)
Patch Set: huangs feedback plus Chromium test fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/browser_distribution.cc ('k') | chrome/installer/util/google_update_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_chrome_distribution.cc
diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc
index 510ec789b08d5db80afaef3800e7f47cf9702fc2..c4701ed1c53e32e4a0f375381429924aedf538ec 100644
--- a/chrome/installer/util/google_chrome_distribution.cc
+++ b/chrome/installer/util/google_chrome_distribution.cc
@@ -23,6 +23,7 @@
#include "base/win/windows_version.h"
#include "chrome/common/chrome_icon_resources_win.h"
#include "chrome/common/chrome_paths_internal.h"
+#include "chrome/install_static/install_util.h"
#include "chrome/installer/util/app_registration_data.h"
#include "chrome/installer/util/channel_info.h"
#include "chrome/installer/util/google_update_constants.h"
@@ -147,7 +148,7 @@ void GoogleChromeDistribution::DoPostUninstallOperations(
}
base::string16 GoogleChromeDistribution::GetActiveSetupGuid() {
- return GetAppGuid();
+ return install_static::GetAppGuid();
}
base::string16 GoogleChromeDistribution::GetBaseAppName() {
@@ -203,7 +204,7 @@ std::string GoogleChromeDistribution::GetSafeBrowsingName() {
base::string16 GoogleChromeDistribution::GetDistributionData(HKEY root_key) {
base::string16 sub_key(google_update::kRegPathClientState);
sub_key.append(L"\\");
- sub_key.append(GetAppGuid());
+ sub_key.append(install_static::GetAppGuid());
base::win::RegKey client_state_key(
root_key, sub_key.c_str(), KEY_READ | KEY_WOW64_32KEY);
@@ -280,9 +281,10 @@ base::string16 GoogleChromeDistribution::GetCommandExecuteImplClsid() {
void GoogleChromeDistribution::UpdateInstallStatus(bool system_install,
installer::ArchiveType archive_type,
installer::InstallStatus install_status) {
- GoogleUpdateSettings::UpdateInstallStatus(system_install,
- archive_type, InstallUtil::GetInstallReturnCode(install_status),
- GetAppGuid());
+ GoogleUpdateSettings::UpdateInstallStatus(
+ system_install, archive_type,
+ InstallUtil::GetInstallReturnCode(install_status),
+ install_static::GetAppGuid());
}
bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
« no previous file with comments | « chrome/installer/util/browser_distribution.cc ('k') | chrome/installer/util/google_update_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698