Use install_static::GetAppGuid in place of BrowserDistribution and AppRegistrationData.

chrome/install_static/install_util_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/install_static/install_util.h"
 
 #include <tuple>
 
+#include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/test/test_reg_util_win.h"
 #include "chrome/install_static/install_details.h"
 #include "chrome/install_static/install_modes.h"
 #include "chrome/install_static/test/scoped_install_details.h"
 #include "chrome_elf/nt_registry/nt_registry.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::ElementsAre;
@@ skipping 315 matching lines @@
   const bool system_level_;
   const ScopedInstallDetails scoped_install_details_;
   const InstallConstants* mode_;
   const HKEY root_key_;
   const nt::ROOT_KEY nt_root_key_;
   registry_util::RegistryOverrideManager override_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(InstallStaticUtilTest);
 };
 
+TEST_P(InstallStaticUtilTest, GetAppGuid) {
+  // For brands that do not integrate with Omaha/Google Update, the app guid is
+  // an empty string.
+  if (!kUseGoogleUpdateIntegration)
+    EXPECT_STREQ(L"", GetAppGuid());
+
+#if defined(GOOGLE_CHROME_BUILD)
+  // The app guids for the brand's install modes; parallel to kInstalLModes.
+  static constexpr const wchar_t* kAppGuids[] = {
+      L"{8A69D345-D564-463c-AFF1-A69D9E530F96}",  // Google Chrome.
+      L"{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20}",  // Google Chrome SxS (canary).

[huangs, 2017/02/27 16:15:14]

NIT: Capitalize "Canary"?

I find it odd that the two GUIDs have different capitalization -- but probably
best to maintain status quo (this includes case-sensitive string comparison
below)...

[grt (UTC plus 2), 2017/02/27 20:53:01]

Done.
Yeah, I find it odd, too. I'll make it all caps here and make the expectation
case-insensitive. This makes sense in any case since the Windows registry is
case-insensitive (it's also insensitive about many other things, but that's
between me and my analyst).

+  };
+  static_assert(arraysize(kAppGuids) == NUM_INSTALL_MODES,
+                "kAppGuids out of date.");
+  EXPECT_STREQ(kAppGuids[std::get<0>(GetParam())], GetAppGuid());
+#else
+  FAIL() << "Not implemented.";

[huangs, 2017/02/27 16:15:14]

So Chromium test will fail?  And if the parameterized test is skipped by  for
Chromium, then #if defined(GOOGLE_CHROME_BUILD) should wrap at a different
level?

[grt (UTC plus 2), 2017/02/27 20:53:01]

I'd meant for the test to exit just after line 349 in the branch up there. The
idea here is for forks to end up with a test failure here so that they know
where to add their own magic app guids.

+#endif
+}
+
 TEST_P(InstallStaticUtilTest, UsageStatsAbsent) {
   EXPECT_FALSE(GetCollectStatsConsent());
 }
 
 TEST_P(InstallStaticUtilTest, UsageStatsZero) {
   SetUsageStat(0, false);
   EXPECT_FALSE(GetCollectStatsConsent());
 }
 
 TEST_P(InstallStaticUtilTest, UsageStatsZeroMedium) {
@@ skipping 63 matching lines @@
                                          testing::Values("user")));
 #else   // GOOGLE_CHROME_BUILD
 // Chromium supports user and system levels.
 INSTANTIATE_TEST_CASE_P(Chromium,
                         InstallStaticUtilTest,
                         testing::Combine(testing::Values(CHROMIUM_INDEX),
                                          testing::Values("user", "system")));
 #endif  // !GOOGLE_CHROME_BUILD
 
 }  // namespace install_static