ui: Fix cc/paint skia type mismatches

ui: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes uses of setFlags(antialias).  The only flag that's ever
used in Chrome is the antialias flag, so this is trying to clean
up the future PaintFlags API to not have to support setFlags.

BUG=671433
Review-Url: https://codereview.chromium.org/2716213002
Cr-Commit-Position: refs/heads/master@{#453493}
Committed: https://chromium.googlesource.com/chromium/src/+/aae3c56f6fc41fbbbb244da56fe52ce7b03c1ec6

[enne (OOO), 2017-02-27 01:02:13]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 01:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-02-27 01:02:30]

enne@chromium.org changed reviewers:
+ danakj@chromium.org, sadrul@chromium.org

[commit-bot: I haz the power, 2017-02-27 01:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 01:54:44]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-02-27 01:56:21]

This should be pretty trivial overall.

https://codereview.chromium.org/2716213002/diff/1/ui/gfx/canvas.h
File ui/gfx/canvas.h (left):

https://codereview.chromium.org/2716213002/diff/1/ui/gfx/canvas.h#oldcode272
ui/gfx/canvas.h:272: void DrawPoint(const Point& p, const cc::PaintFlags&
flags);
Nobody is using DrawPoint anywhere, so removing this here means that PaintCanvas
doesn't need it either.

https://codereview.chromium.org/2716213002/diff/1/ui/gfx/harfbuzz_font_skia.cc
File ui/gfx/harfbuzz_font_skia.cc (right):

https://codereview.chromium.org/2716213002/diff/1/ui/gfx/harfbuzz_font_skia.c...
ui/gfx/harfbuzz_font_skia.cc:95: SkPaint
paint(cc::ToSkPaint(font_data->flags_));
Similar to my comments on https://codereview.chromium.org/2716203002 about text
intercepts, I think cc/paint should should only be about recording, and anything
related to glyphs and rastering and actual text should be deferred to Skia. 
Hence, converting back to SkPaint types here.

https://codereview.chromium.org/2716213002/diff/1/ui/views/controls/slider.cc
File ui/views/controls/slider.cc (right):

https://codereview.chromium.org/2716213002/diff/1/ui/views/controls/slider.cc...
ui/views/controls/slider.cc:305: flags.setAntiAlias(true);
Antialiasing is the only use of setFlags anywhere, so am simplifying to just use
setAntiAlias everywhere.

[sadrul, 2017-02-27 17:21:09]

lgtm

[enne (OOO), 2017-02-28 03:00:04]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-02-28 03:00:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 04:26:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488250804896440, "parent_rev":
"00e91606d2a09284064419ce93c34b6efe5e4c66", "commit_rev":
"aae3c56f6fc41fbbbb244da56fe52ce7b03c1ec6"}

[commit-bot: I haz the power, 2017-02-28 04:28:34]

Description was changed from

==========
ui: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes uses of setFlags(antialias).  The only flag that's ever
used in Chrome is the antialias flag, so this is trying to clean
up the future PaintFlags API to not have to support setFlags.

BUG=671433
==========

to

==========
ui: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes uses of setFlags(antialias).  The only flag that's ever
used in Chrome is the antialias flag, so this is trying to clean
up the future PaintFlags API to not have to support setFlags.

BUG=671433

Review-Url: https://codereview.chromium.org/2716213002
Cr-Commit-Position: refs/heads/master@{#453493}
Committed:
https://chromium.googlesource.com/chromium/src/+/aae3c56f6fc41fbbbb244da56fe5...
==========

[commit-bot: I haz the power, 2017-02-28 04:28:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aae3c56f6fc41fbbbb244da56fe5...