Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Side by Side Diff: ui/native_theme/native_theme_base.cc

Issue 2716213002: ui: Fix cc/paint skia type mismatches (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/native_theme/native_theme_base.h" 5 #include "ui/native_theme/native_theme_base.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 canvas->drawRect(gfx::RectToSkRect(progress_rect), progress_flags); 892 canvas->drawRect(gfx::RectToSkRect(progress_rect), progress_flags);
893 893
894 // Draw the border. 894 // Draw the border.
895 gfx::RectF border_rect(rect); 895 gfx::RectF border_rect(rect);
896 border_rect.Inset(stroke_width / 2.0f, stroke_width / 2.0f); 896 border_rect.Inset(stroke_width / 2.0f, stroke_width / 2.0f);
897 stroke_flags.setColor(kProgressBorderColor); 897 stroke_flags.setColor(kProgressBorderColor);
898 canvas->drawRect(gfx::RectFToSkRect(border_rect), stroke_flags); 898 canvas->drawRect(gfx::RectFToSkRect(border_rect), stroke_flags);
899 } 899 }
900 900
901 void NativeThemeBase::PaintFrameTopArea( 901 void NativeThemeBase::PaintFrameTopArea(
902 SkCanvas* canvas, 902 cc::PaintCanvas* canvas,
903 State state, 903 State state,
904 const gfx::Rect& rect, 904 const gfx::Rect& rect,
905 const FrameTopAreaExtraParams& frame_top_area) const { 905 const FrameTopAreaExtraParams& frame_top_area) const {
906 SkPaint flags; 906 cc::PaintFlags flags;
907 flags.setColor(frame_top_area.default_background_color); 907 flags.setColor(frame_top_area.default_background_color);
908 canvas->drawRect(gfx::RectToSkRect(rect), flags); 908 canvas->drawRect(gfx::RectToSkRect(rect), flags);
909 } 909 }
910 910
911 void NativeThemeBase::AdjustCheckboxRadioRectForPadding(SkRect* rect) const { 911 void NativeThemeBase::AdjustCheckboxRadioRectForPadding(SkRect* rect) const {
912 // By default we only take 1px from right and bottom for the drop shadow. 912 // By default we only take 1px from right and bottom for the drop shadow.
913 rect->iset(rect->x(), rect->y(), rect->right() - 1, rect->bottom() - 1); 913 rect->iset(rect->x(), rect->y(), rect->right() - 1, rect->bottom() - 1);
914 } 914 }
915 915
916 SkColor NativeThemeBase::SaturateAndBrighten(SkScalar* hsv, 916 SkColor NativeThemeBase::SaturateAndBrighten(SkScalar* hsv,
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
1002 SkScalar min_diff = Clamp((hsv1[1] + hsv2[1]) * 1.2f, 0.28f, 0.5f); 1002 SkScalar min_diff = Clamp((hsv1[1] + hsv2[1]) * 1.2f, 0.28f, 0.5f);
1003 SkScalar diff = Clamp(fabs(hsv1[2] - hsv2[2]) / 2, min_diff, 0.5f); 1003 SkScalar diff = Clamp(fabs(hsv1[2] - hsv2[2]) / 2, min_diff, 0.5f);
1004 1004
1005 if (hsv1[2] + hsv2[2] > 1.0) 1005 if (hsv1[2] + hsv2[2] > 1.0)
1006 diff = -diff; 1006 diff = -diff;
1007 1007
1008 return SaturateAndBrighten(hsv2, -0.2f, diff); 1008 return SaturateAndBrighten(hsv2, -0.2f, diff);
1009 } 1009 }
1010 1010
1011 } // namespace ui 1011 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698