blink: Fix cc/paint skia type mismatches

blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2716203002
Cr-Commit-Position: refs/heads/master@{#453521}
Committed: https://chromium.googlesource.com/chromium/src/+/6b6094a419b2d7e45a7ec9dccda1cd5398090c91

[enne (OOO), 2017-02-27 00:52:00]

Description was changed from

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
==========

to

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-02-27 00:53:49]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 00:53:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-02-27 00:54:21]

Description was changed from

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
==========

[enne (OOO), 2017-02-27 00:54:21]

enne@chromium.org changed reviewers:
+ pdr@chromium.org, senorblanco@chromium.org

[commit-bot: I haz the power, 2017-02-27 02:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 02:24:47]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[enne (OOO), 2017-02-27 02:34:07]

Description was changed from

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
==========

to

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-02-27 02:34:36]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 02:34:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 04:29:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 04:29:55]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-02-27 05:17:00]

https://codereview.chromium.org/2716203002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/2716203002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/Font.cpp:407: SkPaint
paint(ToSkPaint(flags));
This is changing back because I think the text intercept code should continue to
live in skia.  Maybe this can get better by only needing the particular SkPaint
bits that change intercepts, but I think this is the right place to cut this
abstraction.

[Stephen White, 2017-02-27 13:44:59]

LGTM

https://codereview.chromium.org/2716203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/FilterEffectBuilder.h (right):

https://codereview.chromium.org/2716203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/FilterEffectBuilder.h:53: const PaintFlags*
fillFlags = nullptr,
Naming nit: while not new to this patch, this typedef is new to me, and I find
the name confusing. I think I understand the motivation (to avoid PaintPaint?),
SkPaint contains things much more heavy weight than "flags". But I can't think
of anything better, so I'll shut up until I do.

[enne (OOO), 2017-02-27 17:42:38]

https://codereview.chromium.org/2716203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/FilterEffectBuilder.h (right):

https://codereview.chromium.org/2716203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/FilterEffectBuilder.h:53: const PaintFlags*
fillFlags = nullptr,
On 2017/02/27 at 13:44:59, Stephen White wrote:
> Naming nit: while not new to this patch, this typedef is new to me, and I find
the name confusing. I think I understand the motivation (to avoid PaintPaint?),
SkPaint contains things much more heavy weight than "flags". But I can't think
of anything better, so I'll shut up until I do.

vmpstr said almost word for word the same thing (and yes, it's to avoid
PaintPaint or cc::Paint).  I'm happy to change it to something more
understandable, but nobody came up with anything better.  :C

[pdr., 2017-02-27 23:22:41]

On 2017/02/27 at 17:42:38, enne wrote:
>
https://codereview.chromium.org/2716203002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/paint/FilterEffectBuilder.h (right):
> 
>
https://codereview.chromium.org/2716203002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/paint/FilterEffectBuilder.h:53: const
PaintFlags* fillFlags = nullptr,
> On 2017/02/27 at 13:44:59, Stephen White wrote:
> > Naming nit: while not new to this patch, this typedef is new to me, and I
find the name confusing. I think I understand the motivation (to avoid
PaintPaint?), SkPaint contains things much more heavy weight than "flags". But I
can't think of anything better, so I'll shut up until I do.
> 
> vmpstr said almost word for word the same thing (and yes, it's to avoid
PaintPaint or cc::Paint).  I'm happy to change it to something more
understandable, but nobody came up with anything better.  :C

LGTM

[enne (OOO), 2017-02-28 02:50:40]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-02-28 02:51:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 06:22:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488250240271570,
"parent_rev": "d071171e53f710f3ac7870f2de47d7bd678720e5", "commit_rev":
"6b6094a419b2d7e45a7ec9dccda1cd5398090c91"}

[commit-bot: I haz the power, 2017-02-28 06:23:30]

Description was changed from

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
blink: Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used, and
removes some unnecessary pass through canvases.

This is a mostly trivial change.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2716203002
Cr-Commit-Position: refs/heads/master@{#453521}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b6094a419b2d7e45a7ec9dccda1...
==========

[commit-bot: I haz the power, 2017-02-28 06:23:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6b6094a419b2d7e45a7ec9dccda1...