Replace all enums with enum classes in permissions code.

Replace all enums with enum classes in permissions code.

This CL removes all unqualified enums in permissions code and replaces
them with enum classes. This improves readability, at the small cost of
requiring static_cast<int> when recording UMA metrics.

BUG=695315
TBR=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2715643002
Cr-Commit-Position: refs/heads/master@{#452663}
Committed: https://chromium.googlesource.com/chromium/src/+/2e27deaf15dd4cd8462c122479c7c15f69faa80d

[dominickn, 2017-02-23 05:04:53]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 05:05:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-02-23 05:08:52]

dominickn@chromium.org changed reviewers:
+ nparker@chromium.org, raymes@chromium.org

[dominickn, 2017-02-23 05:08:53]

PTAL, thanks!

[commit-bot: I haz the power, 2017-02-23 06:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 06:10:02]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-02-23 06:41:28]

lgtm, thanks!

[dominickn, 2017-02-23 21:36:59]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 21:37:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-02-23 21:40:27]

Description was changed from

==========
Replace all enums with enum classes in permissions code.

This CL removes all unqualified enums in permissions code and replaces
them with enum classes. This improves readability, at the small cost of
requiring static_cast<int> when recording UMA metrics.

BUG=695315
==========

to

==========
Replace all enums with enum classes in permissions code.

This CL removes all unqualified enums in permissions code and replaces
them with enum classes. This improves readability, at the small cost of
requiring static_cast<int> when recording UMA metrics.

BUG=695315
TBR=nparker@chromium.org
==========

[commit-bot: I haz the power, 2017-02-23 22:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:30:56]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-02-23 22:37:35]

TBR'ing nparker as the safe browsing changes are just specifying an enum class
type.

[dominickn, 2017-02-23 22:48:18]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2017-02-23 22:48:18]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2715643002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-23 22:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:00:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487890098120840,
"parent_rev": "a43e3a47cfb447baea81b528030fd2c801fd2b0d", "commit_rev":
"2e27deaf15dd4cd8462c122479c7c15f69faa80d"}

[commit-bot: I haz the power, 2017-02-23 23:01:15]

Description was changed from

==========
Replace all enums with enum classes in permissions code.

This CL removes all unqualified enums in permissions code and replaces
them with enum classes. This improves readability, at the small cost of
requiring static_cast<int> when recording UMA metrics.

BUG=695315
TBR=nparker@chromium.org
==========

to

==========
Replace all enums with enum classes in permissions code.

This CL removes all unqualified enums in permissions code and replaces
them with enum classes. This improves readability, at the small cost of
requiring static_cast<int> when recording UMA metrics.

BUG=695315
TBR=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2715643002
Cr-Commit-Position: refs/heads/master@{#452663}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e27deaf15dd4cd8462c122479c7...
==========

[commit-bot: I haz the power, 2017-02-23 23:01:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2e27deaf15dd4cd8462c122479c7...

[Nathan Parker, 2017-02-27 21:33:47]

lgtm