Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4408)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2715643002: Replace all enums with enum classes in permissions code. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index de92418b9a0aa216210a385293d73a3ab9e41ddd..a8e67aab0497befb3aabb57ec876d1cb5c410380 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -27,7 +27,7 @@ enum class PermissionSourceUI {
PAGE_ACTION = 3,
// Always keep this at the end.
- SOURCE_UI_NUM,
+ NUM,
};
// This should stay in sync with the PersistDecision enum in the permission
@@ -38,24 +38,24 @@ enum class PermissionPersistDecision {
NOT_PERSISTED = 2,
};
-// Any new values should be inserted immediately prior to RESPONSE_NUM.
-enum SafeBrowsingResponse {
+// Any new values should be inserted immediately prior to NUM.
+enum class SafeBrowsingResponse {
NOT_BLACKLISTED = 0,
TIMEOUT = 1,
BLACKLISTED = 2,
// Always keep this at the end.
- RESPONSE_NUM,
+ NUM,
};
-// Any new values should be inserted immediately prior to STATUS_NUM.
-enum PermissionEmbargoStatus {
+// Any new values should be inserted immediately prior to NUM.
+enum class PermissionEmbargoStatus {
NOT_EMBARGOED = 0,
PERMISSIONS_BLACKLISTING = 1,
REPEATED_DISMISSALS = 2,
// Keep this at the end.
- STATUS_NUM,
+ NUM,
};
// A bundle for the information sent in a PermissionReport.
« no previous file with comments | « chrome/browser/permissions/permission_queue_controller.cc ('k') | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698