Make the PermissionDecisionAutoBlocker API consistent.

Make the PermissionDecisionAutoBlocker API consistent.

This CL standardises the argument and method ordering for
PermissionDecisionAutoBlocker to make it more consistent.

BUG=679877
Review-Url: https://codereview.chromium.org/2709213004
Cr-Commit-Position: refs/heads/master@{#452658}
Committed: https://chromium.googlesource.com/chromium/src/+/f5b5d2155c0b5820cf2d354ee784ff16f5186853

[dominickn, 2017-02-23 04:47:01]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 04:47:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-02-23 04:47:27]

dominickn@chromium.org changed reviewers:
+ raymes@chromium.org

[dominickn, 2017-02-23 04:47:27]

PTAL, thanks! I split up the enum replacement out of this CL to keep it smaller
:)

[commit-bot: I haz the power, 2017-02-23 05:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 05:53:42]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-02-23 06:09:30]

Thanks for breaking them up, much appreciated!

lgtm

https://codereview.chromium.org/2709213004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_decision_auto_blocker.h (right):

https://codereview.chromium.org/2709213004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.h:64: // Makes an
asynchronous call to Safe Browsing to check the API blacklist.
nit: you may also want to note that the result will be stored and impact the
result of |GetEmabrgoResult|?

[dominickn, 2017-02-23 06:14:19]

Thanks!

https://codereview.chromium.org/2709213004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_decision_auto_blocker.h (right):

https://codereview.chromium.org/2709213004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.h:64: // Makes an
asynchronous call to Safe Browsing to check the API blacklist.
On 2017/02/23 06:09:30, raymes wrote:
> nit: you may also want to note that the result will be stored and impact the
> result of |GetEmabrgoResult|?

Done.

[msramek, 2017-02-23 13:17:55]

msramek@chromium.org changed reviewers:
+ msramek@chromium.org

[msramek, 2017-02-23 13:17:55]

LGTM (I know you didn't ask and can TBR this, but I have a watchlist, so why not
:) )

[dominickn, 2017-02-23 21:36:09]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 21:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:29:43]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-02-23 22:34:23]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2017-02-23 22:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org,
msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2709213004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-23 22:35:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:46:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487889263771450,
"parent_rev": "106c52c87b9deeb8be9127466bec935b695369d3", "commit_rev":
"f5b5d2155c0b5820cf2d354ee784ff16f5186853"}

[commit-bot: I haz the power, 2017-02-23 22:47:02]

Description was changed from

==========
Make the PermissionDecisionAutoBlocker API consistent.

This CL standardises the argument and method ordering for
PermissionDecisionAutoBlocker to make it more consistent.

BUG=679877
==========

to

==========
Make the PermissionDecisionAutoBlocker API consistent.

This CL standardises the argument and method ordering for
PermissionDecisionAutoBlocker to make it more consistent.

BUG=679877

Review-Url: https://codereview.chromium.org/2709213004
Cr-Commit-Position: refs/heads/master@{#452658}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5b5d2155c0b5820cf2d354ee784...
==========

[commit-bot: I haz the power, 2017-02-23 22:47:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f5b5d2155c0b5820cf2d354ee784...