Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2715623003: Split out PermissionResult and PermissionStatusSource into a new cc/h file. (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split out PermissionResult and PermissionStatusSource into a new cc/h file. BUG=679877 Review-Url: https://codereview.chromium.org/2715623003 Cr-Commit-Position: refs/heads/master@{#452736} Committed: https://chromium.googlesource.com/chromium/src/+/3c20e2d031c75de77442d5dbb6cca41adaf390f6

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Re-rebase #

Patch Set 4 : Re-re-rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -35 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/permissions/permission_decision_auto_blocker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_decision_auto_blocker.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/permissions/permission_result.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/permissions/permission_result.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_util.h View 1 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/permissions/permission_util.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
dominickn
PTAL, thanks!
3 years, 10 months ago (2017-02-23 05:19:35 UTC) #4
raymes
lgtm, thanks for this!
3 years, 10 months ago (2017-02-23 06:10:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715623003/60001
3 years, 9 months ago (2017-02-24 03:11:52 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 03:19:08 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3c20e2d031c75de77442d5dbb6cc...

Powered by Google App Engine
This is Rietveld 408576698