Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2712443002: NQE: Move ECT computation to NotifyHeadersReceived (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

NQE: Move ECT computation to NotifyHeadersReceived Currently, NQE (Network Quality Estimator) computes the effective connection type when the transaction starts. This CL moves the computation of effective connection type to when the response headers are received. BUG=691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2703103002 Cr-Commit-Position: refs/heads/master@{#451535} (cherry picked from commit 747aab0de56d72b41287c65befbee89dfa433739) NQE: Move recording of metrics to when the response headers are received Currently, NQE (Network Quality Estimator) records the network quality metrics when the transaction starts. This CL moves the recording of the metrics to when the response headers are received. BUG=691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2702013002 Cr-Commit-Position: refs/heads/master@{#451446} (cherry picked from commit 69415b51072fb20605fc129f136950f7c2560ceb) NQE: Record the main frame metrics at transaction start In network quality estimator (NQE), record the main frame metrics at the beginning of transaction start, instead of when the response headers have been received for the main frame. BUG=691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2695783003 Cr-Commit-Position: refs/heads/master@{#450536} (cherry picked from commit 0be260cab40bb7162d01d99afb1144abdd2469c2) Review-Url: https://codereview.chromium.org/2712443002 . Cr-Commit-Position: refs/branch-heads/2987@{#608} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/443abf275b957869722ec105d9a4d35cd71590c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -58 lines) Patch
M net/nqe/network_quality_estimator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 3 chunks +23 lines, -22 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 8 chunks +41 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
tbansal1
3 years, 10 months ago (2017-02-21 17:26:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
443abf275b957869722ec105d9a4d35cd71590c8.

Powered by Google App Engine
This is Rietveld 408576698