NQE: Record the main frame metrics at transaction start

NQE: Record the main frame metrics at transaction start

In network quality estimator (NQE), record the main frame metrics at the 
beginning of transaction start, instead of when the response headers have
been received for the main frame.

BUG=691798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2695783003
Cr-Commit-Position: refs/heads/master@{#450536}
Committed: https://chromium.googlesource.com/chromium/src/+/0be260cab40bb7162d01d99afb1144abdd2469c2

[tbansal1, 2017-02-13 22:03:44]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-02-13 22:04:07]

Description was changed from

==========
NQE move recording the accuracy code

BUG=
==========

to

==========
NQE move recording the accuracy code

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-13 23:28:29]

Description was changed from

==========
NQE move recording the accuracy code

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NQE: Record the main frame metrics at transaction start

In network quality estimator (NQE), record the main frame metrics at the 
beginning of transaction start, instead of when the response headers have
been received for the main frame.

BUG=691798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-13 23:28:42]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-02-13 23:28:43]

ryansturm: ptal. Thanks.

[tbansal1, 2017-02-14 01:39:34]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 01:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 03:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 03:33:42]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-02-14 18:12:53]

There's a few stale comments in network_quality_estimator.h, can you also check
if anything in histograms.xml needs to be updated to reflect this change (I
didn't check)?

https://codereview.chromium.org/2695783003/diff/20001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2695783003/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:410: last_main_frame_request_ = now;
Update comments in .h file about last_main_frame_request_ and anything else
referencing headers received vs start transaction.

[tbansal1, 2017-02-14 21:49:05]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2017-02-14 21:49:44]

Updated comments in the header file. I did not find anything interesting in
histograms.xml. ptal. Thanks.

https://codereview.chromium.org/2695783003/diff/20001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2695783003/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:410: last_main_frame_request_ = now;
On 2017/02/14 18:12:53, Ryan Sturm wrote:
> Update comments in .h file about last_main_frame_request_ and anything else
> referencing headers received vs start transaction.

Done.

[tbansal1, 2017-02-14 21:49:48]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:50:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 23:33:33]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-02-14 23:33:54]

lgtm

[tbansal1, 2017-02-15 00:25:05]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:25:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:16:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487118305687490,
"parent_rev": "0178428f6e9f682eb526fe95b78374448f40d9ff", "commit_rev":
"0be260cab40bb7162d01d99afb1144abdd2469c2"}

[commit-bot: I haz the power, 2017-02-15 01:17:11]

Description was changed from

==========
NQE: Record the main frame metrics at transaction start

In network quality estimator (NQE), record the main frame metrics at the 
beginning of transaction start, instead of when the response headers have
been received for the main frame.

BUG=691798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NQE: Record the main frame metrics at transaction start

In network quality estimator (NQE), record the main frame metrics at the 
beginning of transaction start, instead of when the response headers have
been received for the main frame.

BUG=691798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2695783003
Cr-Commit-Position: refs/heads/master@{#450536}
Committed:
https://chromium.googlesource.com/chromium/src/+/0be260cab40bb7162d01d99afb11...
==========

[commit-bot: I haz the power, 2017-02-15 01:17:12]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0be260cab40bb7162d01d99afb11...

[tbansal1, 2017-02-16 19:51:10]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2690303011/ by tbansal@chromium.org.

The reason for reverting is: Caused perf regression. See
https://bugs.chromium.org/p/chromium/issues/detail?id=692933.