Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2702013002: NQE: Move recording of metrics to when the response headers are received (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NQE: Move recording of metrics to when the response headers are received Currently, NQE (Network Quality Estimator) records the network quality metrics when the transaction starts. This CL moves the recording of the metrics to when the response headers are received. BUG=691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester TBR=ryansturm@chromium.org Review-Url: https://codereview.chromium.org/2702013002 Cr-Commit-Position: refs/heads/master@{#451446} Committed: https://chromium.googlesource.com/chromium/src/+/69415b51072fb20605fc129f136950f7c2560ceb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/nqe/network_quality_estimator.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
tbansal1
TBR'ing ryansturm to see if this fixes issues with the perf bot, and also because ...
3 years, 10 months ago (2017-02-18 09:00:27 UTC) #9
tbansal1
3 years, 10 months ago (2017-02-18 09:00:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702013002/1
3 years, 10 months ago (2017-02-18 09:00:56 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 09:04:34 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69415b51072fb20605fc129f1369...

Powered by Google App Engine
This is Rietveld 408576698