Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2703103002: NQE: Move ECT computation to NotifyHeadersReceived (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NQE: Move ECT computation to NotifyHeadersReceived Currently, NQE (Network Quality Estimator) computes the effective connection type when the transaction starts. This CL moves the computation of effective connection type to when the response headers are received. BUG=691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester TBR=ryansturm@chromium.org Review-Url: https://codereview.chromium.org/2703103002 Cr-Commit-Position: refs/heads/master@{#451535} Committed: https://chromium.googlesource.com/chromium/src/+/747aab0de56d72b41287c65befbee89dfa433739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/nqe/network_quality_estimator.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (9 generated)
tbansal1
TBR'ing ryansturm to see if this fixes issues with the perf bot, and also because ...
3 years, 10 months ago (2017-02-20 00:45:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703103002/1
3 years, 10 months ago (2017-02-20 00:46:05 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 00:50:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/747aab0de56d72b41287c65befbe...

Powered by Google App Engine
This is Rietveld 408576698