Mac accessibility: Add support for AXDOMIdentifier

Mac accessibility: Add support for AXDOMIdentifier

The Mac NSAccessibility protocol uses AXDOMIdentifier as a way to expose
an HTML element's ID.

This will be helpful to enable writing cross-browser accessibility tests.

BUG=695908
TBR=aboxhall@chromium.org

Review-Url: https://codereview.chromium.org/2712153002
Cr-Commit-Position: refs/heads/master@{#453011}
Committed: https://chromium.googlesource.com/chromium/src/+/33880922f9981c5db4f91c6cdf702f75f59261c6

[dmazzoni, 2017-02-24 17:02:12]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-02-24 17:02:32]

dmazzoni@chromium.org changed reviewers:
+ aleventhal@chromium.org

[commit-bot: I haz the power, 2017-02-24 17:02:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-02-24 17:41:37]

LGTM with the caveat about the whitespace changes that I commented about.

https://codereview.chromium.org/2712153002/diff/20001/content/browser/accessi...
File content/browser/accessibility/accessibility_tree_formatter_mac.mm (right):

https://codereview.chromium.org/2712153002/diff/20001/content/browser/accessi...
content/browser/accessibility/accessibility_tree_formatter_mac.mm:147:
arrayWithObjects:NSAccessibilityRoleDescriptionAttribute,
Are the whitespace changes on purpose? Makes it harder to see what the change
is. I imagine you're only adding the new property, but it's hard to see that for
sure.

[commit-bot: I haz the power, 2017-02-24 18:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 18:27:04]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-02-24 19:22:03]

https://codereview.chromium.org/2712153002/diff/20001/content/browser/accessi...
File content/browser/accessibility/accessibility_tree_formatter_mac.mm (right):

https://codereview.chromium.org/2712153002/diff/20001/content/browser/accessi...
content/browser/accessibility/accessibility_tree_formatter_mac.mm:147:
arrayWithObjects:NSAccessibilityRoleDescriptionAttribute,
On 2017/02/24 17:41:37, aleventhal wrote:
> Are the whitespace changes on purpose? Makes it harder to see what the change
> is. I imagine you're only adding the new property, but it's hard to see that
for
> sure.

Ugh. Yeah, the presubmit had me run "git cl format",
but I didn't realize at first that it not only
indented but put more than one on a line. I definitely
don't like that.

Let me figure out how to disable the standard formatting
rule for this list.

[dmazzoni, 2017-02-24 22:43:36]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-02-24 22:43:56]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2017-02-24 22:44:11]

Description was changed from

==========
Mac accessibility: Add support for AXDOMIdentifier

The Mac NSAccessibility protocol uses AXDOMIdentifier as a way to expose
an HTML element's ID.

This will be helpful to enable writing cross-browser accessibility tests.

BUG=695908
==========

to

==========
Mac accessibility: Add support for AXDOMIdentifier

The Mac NSAccessibility protocol uses AXDOMIdentifier as a way to expose
an HTML element's ID.

This will be helpful to enable writing cross-browser accessibility tests.

BUG=695908
TBR=aboxhall@chromium.org
==========

[commit-bot: I haz the power, 2017-02-24 22:44:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-02-24 22:44:19]

+aboxhall as TBR

[dmazzoni, 2017-02-24 22:44:25]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2017-02-24 22:44:33]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-02-24 22:44:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
aleventhal@chromium.org
Link to the patchset: https://codereview.chromium.org/2712153002/#ps40001
(title: "Revert clang-format")

[commit-bot: I haz the power, 2017-02-24 22:45:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:15:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487976273622610,
"parent_rev": "7525a848b3036662353f3d3b244fa4e3e9114f9e", "commit_rev":
"33880922f9981c5db4f91c6cdf702f75f59261c6"}

[commit-bot: I haz the power, 2017-02-25 00:16:24]

Description was changed from

==========
Mac accessibility: Add support for AXDOMIdentifier

The Mac NSAccessibility protocol uses AXDOMIdentifier as a way to expose
an HTML element's ID.

This will be helpful to enable writing cross-browser accessibility tests.

BUG=695908
TBR=aboxhall@chromium.org
==========

to

==========
Mac accessibility: Add support for AXDOMIdentifier

The Mac NSAccessibility protocol uses AXDOMIdentifier as a way to expose
an HTML element's ID.

This will be helpful to enable writing cross-browser accessibility tests.

BUG=695908
TBR=aboxhall@chromium.org

Review-Url: https://codereview.chromium.org/2712153002
Cr-Commit-Position: refs/heads/master@{#453011}
Committed:
https://chromium.googlesource.com/chromium/src/+/33880922f9981c5db4f91c6cdf70...
==========

[commit-bot: I haz the power, 2017-02-25 00:16:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/33880922f9981c5db4f91c6cdf70...