Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_mac.mm

Issue 2712153002: Mac accessibility: Add support for AXDOMIdentifier (Closed)
Patch Set: Revert clang-format Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/accessibility_tree_formatter_mac.mm
diff --git a/content/browser/accessibility/accessibility_tree_formatter_mac.mm b/content/browser/accessibility/accessibility_tree_formatter_mac.mm
index 283fe19c96642dbc9ae9614338c7a735e77b6523..a844a94bd0495709837cd85f71b85aa2b81fa98d 100644
--- a/content/browser/accessibility/accessibility_tree_formatter_mac.mm
+++ b/content/browser/accessibility/accessibility_tree_formatter_mac.mm
@@ -143,6 +143,9 @@ std::unique_ptr<base::Value> PopulateObject(id value) {
}
NSArray* BuildAllAttributesArray() {
+ // Note: clang-format tries to put multiple attributes on one line,
+ // but we prefer to have one per line for readability.
+ // clang-format off
NSArray* array = [NSArray arrayWithObjects:
NSAccessibilityRoleDescriptionAttribute,
NSAccessibilityTitleAttribute,
@@ -167,6 +170,7 @@ NSArray* BuildAllAttributesArray() {
@"AXARIASetSize",
@"AXARIAPosInSet",
NSAccessibilityColumnIndexRangeAttribute,
+ @"AXDOMIdentifier",
@"AXDropEffects",
NSAccessibilityEnabledAttribute,
NSAccessibilityExpandedAttribute,
@@ -189,6 +193,8 @@ NSArray* BuildAllAttributesArray() {
@"AXVisited",
@"AXLinkedUIElements",
nil];
+ // clang-format off
+
return [array retain];
}
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698