Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2712153002: Mac accessibility: Add support for AXDOMIdentifier (Closed)
Patch Set: Revert clang-format Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index 9e76be179b533098878b4da08f91d501bf0d225e..4f0b05a50f94c482d9cbd5d3791b7700c9d5d26c 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -60,6 +60,7 @@ NSString* const NSAccessibilityARIARowCountAttribute = @"AXARIARowCount";
NSString* const NSAccessibilityARIARowIndexAttribute = @"AXARIARowIndex";
NSString* const NSAccessibilityARIASetSizeAttribute = @"AXARIASetSize";
NSString* const NSAccessibilityAccessKeyAttribute = @"AXAccessKey";
+NSString* const NSAccessibilityDOMIdentifierAttribute = @"AXDOMIdentifier";
NSString* const NSAccessibilityDropEffectsAttribute = @"AXDropEffects";
NSString* const NSAccessibilityGrabbedAttribute = @"AXGrabbed";
NSString* const NSAccessibilityInvalidAttribute = @"AXInvalid";
@@ -552,6 +553,7 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
{NSAccessibilityDisclosureLevelAttribute, @"disclosureLevel"},
{NSAccessibilityDisclosedRowsAttribute, @"disclosedRows"},
{NSAccessibilityDropEffectsAttribute, @"dropEffects"},
+ {NSAccessibilityDOMIdentifierAttribute, @"domIdentifier"},
{NSAccessibilityEnabledAttribute, @"enabled"},
{NSAccessibilityEndTextMarkerAttribute, @"endTextMarker"},
{NSAccessibilityExpandedAttribute, @"expanded"},
@@ -944,6 +946,17 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
return nil;
}
+- (NSString*)domIdentifier {
+ if (![self instanceActive])
+ return nil;
+
+ std::string id;
+ if (browserAccessibility_->GetHtmlAttribute("id", &id))
+ return base::SysUTF8ToNSString(id);
+
+ return nil;
+}
+
- (NSNumber*)enabled {
if (![self instanceActive])
return nil;
@@ -2555,6 +2568,7 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
arrayWithObjects:NSAccessibilityAccessKeyAttribute,
NSAccessibilityChildrenAttribute,
NSAccessibilityDescriptionAttribute,
+ NSAccessibilityDOMIdentifierAttribute,
NSAccessibilityEnabledAttribute,
NSAccessibilityEndTextMarkerAttribute,
NSAccessibilityFocusedAttribute,

Powered by Google App Engine
This is Rietveld 408576698