Mac accessibility: Add support for AXDOMIdentifier

content/browser/accessibility/accessibility_tree_formatter_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/accessibility_tree_formatter.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/files/file_path.h"
 #include "base/json/json_writer.h"
@@ skipping 125 matching lines @@
     StringForBrowserAccessibility(value)->GetAsString(&str);
     return std::unique_ptr<base::Value>(
         StringForBrowserAccessibility((BrowserAccessibilityCocoa*)value));
   }
 
   return std::unique_ptr<base::Value>(new base::StringValue(
       SysNSStringToUTF16([NSString stringWithFormat:@"%@", value])));
 }
 
 NSArray* BuildAllAttributesArray() {
-  NSArray* array = [NSArray arrayWithObjects:
-      NSAccessibilityRoleDescriptionAttribute,
-      NSAccessibilityTitleAttribute,
-      NSAccessibilityValueAttribute,
-      NSAccessibilityMinValueAttribute,
-      NSAccessibilityMaxValueAttribute,
-      NSAccessibilityValueDescriptionAttribute,
-      NSAccessibilityDescriptionAttribute,
-      NSAccessibilityHelpAttribute,
-      @"AXInvalid",
-      NSAccessibilityDisclosingAttribute,
-      NSAccessibilityDisclosureLevelAttribute,
-      @"AXAccessKey",
-      @"AXARIAAtomic",
-      @"AXARIABusy",
-      @"AXARIAColumnCount",
-      @"AXARIAColumnIndex",
-      @"AXARIALive",
-      @"AXARIARelevant",
-      @"AXARIARowCount",
-      @"AXARIARowIndex",
-      @"AXARIASetSize",
-      @"AXARIAPosInSet",
-      NSAccessibilityColumnIndexRangeAttribute,
-      @"AXDropEffects",
-      NSAccessibilityEnabledAttribute,
-      NSAccessibilityExpandedAttribute,
-      NSAccessibilityFocusedAttribute,
-      @"AXGrabbed",
-      NSAccessibilityIndexAttribute,
-      @"AXLoaded",
-      @"AXLoadingProcess",
-      NSAccessibilityNumberOfCharactersAttribute,
-      NSAccessibilitySortDirectionAttribute,
-      NSAccessibilityOrientationAttribute,
-      NSAccessibilityPlaceholderValueAttribute,
-      @"AXRequired",
-      NSAccessibilityRowIndexRangeAttribute,
-      NSAccessibilitySelectedChildrenAttribute,
-      NSAccessibilityTitleUIElementAttribute,
-      NSAccessibilityURLAttribute,
-      NSAccessibilityVisibleCharacterRangeAttribute,
-      NSAccessibilityVisibleChildrenAttribute,
-      @"AXVisited",
-      @"AXLinkedUIElements",
-      nil];
+  NSArray* array = [NSArray
+      arrayWithObjects:NSAccessibilityRoleDescriptionAttribute,

[aleventhal, 2017/02/24 17:41:37]

Are the whitespace changes on purpose? Makes it harder to see what the change
is. I imagine you're only adding the new property, but it's hard to see that for
sure.

[dmazzoni, 2017/02/24 19:22:03]

Ugh. Yeah, the presubmit had me run "git cl format",
but I didn't realize at first that it not only
indented but put more than one on a line. I definitely
don't like that.

Let me figure out how to disable the standard formatting
rule for this list.

+                       NSAccessibilityTitleAttribute,
+                       NSAccessibilityValueAttribute,
+                       NSAccessibilityMinValueAttribute,
+                       NSAccessibilityMaxValueAttribute,
+                       NSAccessibilityValueDescriptionAttribute,
+                       NSAccessibilityDescriptionAttribute,
+                       NSAccessibilityHelpAttribute, @"AXInvalid",
+                       NSAccessibilityDisclosingAttribute,
+                       NSAccessibilityDisclosureLevelAttribute, @"AXAccessKey",
+                       @"AXARIAAtomic", @"AXARIABusy", @"AXARIAColumnCount",
+                       @"AXARIAColumnIndex", @"AXARIALive", @"AXARIARelevant",
+                       @"AXARIARowCount", @"AXARIARowIndex", @"AXARIASetSize",
+                       @"AXARIAPosInSet",
+                       NSAccessibilityColumnIndexRangeAttribute,
+                       @"AXDOMIdentifier", @"AXDropEffects",
+                       NSAccessibilityEnabledAttribute,
+                       NSAccessibilityExpandedAttribute,
+                       NSAccessibilityFocusedAttribute, @"AXGrabbed",
+                       NSAccessibilityIndexAttribute, @"AXLoaded",
+                       @"AXLoadingProcess",
+                       NSAccessibilityNumberOfCharactersAttribute,
+                       NSAccessibilitySortDirectionAttribute,
+                       NSAccessibilityOrientationAttribute,
+                       NSAccessibilityPlaceholderValueAttribute, @"AXRequired",
+                       NSAccessibilityRowIndexRangeAttribute,
+                       NSAccessibilitySelectedChildrenAttribute,
+                       NSAccessibilityTitleUIElementAttribute,
+                       NSAccessibilityURLAttribute,
+                       NSAccessibilityVisibleCharacterRangeAttribute,
+                       NSAccessibilityVisibleChildrenAttribute, @"AXVisited",
+                       @"AXLinkedUIElements", nil];
   return [array retain];
 }
 
 }  // namespace
 
 class AccessibilityTreeFormatterMac : public AccessibilityTreeFormatter {
  public:
   explicit AccessibilityTreeFormatterMac();
   ~AccessibilityTreeFormatterMac() override;
 
@@ skipping 132 matching lines @@
 
 const string AccessibilityTreeFormatterMac::GetAllowString() {
   return "@MAC-ALLOW:";
 }
 
 const string AccessibilityTreeFormatterMac::GetDenyString() {
   return "@MAC-DENY:";
 }
 
 }  // namespace content