[DevTools] Migrate Popover to GlassPane

[DevTools] Migrate Popover to GlassPane

- Removed one more modal primitive.
- Fixed multiple bugs with wrong arrow position.
- Made popover work great when not enough space (e.g. color swatch now scrolls).
- Migrated to UI.Icon for arrows.

Further API simplification of Popover/GlassPane to follow.

BUG=none

Review-Url: https://codereview.chromium.org/2712063002
Cr-Commit-Position: refs/heads/master@{#455301}
Committed: https://chromium.googlesource.com/chromium/src/+/72b6d79734c7fd5925b6f862c588229b0207afe6

[dgozman, 2017-03-07 01:20:22]

Description was changed from

==========
[DevTools] Migrate Popover to GlassPane.

One more modal component is gone.

BUG=none
==========

to

==========
[DevTools] Migrate Popover to GlassPane

- Removed one more modal primitive.
- Fixed multiple bugs with wrong arrow position.
- Made popover work great when not enough space (e.g. color swatch now scrolls).
- Migrated to UI.Icon for arrows.

Further API simplification of Popover/GlassPane to follow.

BUG=none
==========

[dgozman, 2017-03-07 01:20:29]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-03-07 01:20:41]

dgozman@chromium.org changed reviewers:
+ alph@chromium.org

[dgozman, 2017-03-07 01:20:42]

Mind taking a look?

[commit-bot: I haz the power, 2017-03-07 01:21:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-03-07 02:39:10]

lgtm

https://codereview.chromium.org/2712063002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right):

https://codereview.chromium.org/2712063002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:194:
this._arrowElement.classList.remove('arrow-none');
nit: remove accepts multiple arguments

[commit-bot: I haz the power, 2017-03-07 04:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:00:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2017-03-07 21:33:50]

https://codereview.chromium.org/2712063002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right):

https://codereview.chromium.org/2712063002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:194:
this._arrowElement.classList.remove('arrow-none');
On 2017/03/07 02:39:10, alph wrote:
> nit: remove accepts multiple arguments

Done.

[dgozman, 2017-03-07 21:33:53]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-07 21:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2712063002/#ps100001
(title: "nit")

[commit-bot: I haz the power, 2017-03-07 21:35:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:01:31]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488922433961690,
"parent_rev": "35cb1d3e7a0b1ebe62b485ff06bf641a01d8c36a", "commit_rev":
"72b6d79734c7fd5925b6f862c588229b0207afe6"}

[commit-bot: I haz the power, 2017-03-08 00:04:26]

Description was changed from

==========
[DevTools] Migrate Popover to GlassPane

- Removed one more modal primitive.
- Fixed multiple bugs with wrong arrow position.
- Made popover work great when not enough space (e.g. color swatch now scrolls).
- Migrated to UI.Icon for arrows.

Further API simplification of Popover/GlassPane to follow.

BUG=none
==========

to

==========
[DevTools] Migrate Popover to GlassPane

- Removed one more modal primitive.
- Fixed multiple bugs with wrong arrow position.
- Made popover work great when not enough space (e.g. color swatch now scrolls).
- Migrated to UI.Icon for arrows.

Further API simplification of Popover/GlassPane to follow.

BUG=none

Review-Url: https://codereview.chromium.org/2712063002
Cr-Commit-Position: refs/heads/master@{#455301}
Committed:
https://chromium.googlesource.com/chromium/src/+/72b6d79734c7fd5925b6f862c588...
==========

[commit-bot: I haz the power, 2017-03-08 00:04:27]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/72b6d79734c7fd5925b6f862c588...