Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html

Issue 2712063002: [DevTools] Migrate Popover to GlassPane (Closed)
Patch Set: nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html
diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html b/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html
index 9dc6bdcb5bd049ec405a465eab3c3e1463217207..bed51f26525ff422b4e57e9cd482ddf8e35ec7f5 100644
--- a/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html
+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html
@@ -23,10 +23,10 @@ function test() {
var swatch = treeItem.valueElement.querySelector("span[is=color-swatch]").shadowRoot.querySelector(".color-swatch-inner");
swatch.dispatchEvent(createShiftClick());
InspectorTest.addResult("After shift-click: " + treeItem.valueElement.textContent);
- InspectorTest.addResult("Has popover before click: " + !!document.querySelector("body > .popover-container"));
+ InspectorTest.addResult("Has popover before click: " + popoverVisible());
swatch.click();
- InspectorTest.addResult("Has popover after click: " + !!document.querySelector("body > .popover-container"));
+ InspectorTest.addResult("Has popover after click: " + popoverVisible());
next();
},
@@ -56,6 +56,11 @@ function test() {
event.initMouseEvent("click", true, true, null, 1, 0, 0, 0, 0, false, false, true, false, 0, null);
return event;
}
+
+ function popoverVisible()
+ {
+ return UI.Popover._popover ? UI.Popover._popover.contentElement.isSelfOrDescendant(document.body) : false;
+ }
}
</script>
</head>
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698