[DevTools] Migrate Popover to GlassPane

third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
index 4036111edd0caf378b969a85449b5918d73b48bf..a6ab9a8fbbade1fbf06c0ed9cc13e5474121c051 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
@@ -28,32 +28,25 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-/**
- * @unrestricted
- */
-UI.Popover = class extends UI.Widget {
+UI.Popover = class extends UI.GlassPane {
   /**
    * @param {!UI.PopoverHelper=} popoverHelper
    */
   constructor(popoverHelper) {
-    super(true);
-    this.markAsRoot();
+    super();
     this.registerRequiredCSS('ui/popover.css');
-    this._containerElement = createElementWithClass('div', 'fill popover-container');
-    this._popupArrowElement = this.contentElement.createChild('div', 'arrow');
-    this._contentDiv = this.contentElement.createChild('div', 'popover-content');
+    this.setBlockPointerEvents(false);
+    this.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);
+    this.setShowArrow(true);
     this._popoverHelper = popoverHelper;
-    this._hideBound = this.hide.bind(this);
   }
 
   /**
    * @param {!Element} element
    * @param {!Element|!AnchorBox} anchor
-   * @param {?number=} preferredWidth
-   * @param {?number=} preferredHeight
    */
-  showForAnchor(element, anchor, preferredWidth, preferredHeight) {
-    this._innerShow(null, element, anchor, preferredWidth, preferredHeight);
+  showForAnchor(element, anchor) {
+    this._innerShow(null, element, anchor);
   }
 
   /**
@@ -65,159 +58,50 @@ UI.Popover = class extends UI.Widget {
   }
 
   /**
-   * @param {?UI.Widget} view
+   * @param {?UI.Widget} widget
    * @param {!Element} contentElement
    * @param {!Element|!AnchorBox} anchor
-   * @param {?number=} preferredWidth
-   * @param {?number=} preferredHeight
    */
-  _innerShow(view, contentElement, anchor, preferredWidth, preferredHeight) {
-    this._contentElement = contentElement;
-
+  _innerShow(widget, contentElement, anchor) {
     // This should not happen, but we hide previous popup to be on the safe side.
     if (UI.Popover._popover)
       UI.Popover._popover.hide();
     UI.Popover._popover = this;
 
-    var document = anchor instanceof Element ? anchor.ownerDocument : contentElement.ownerDocument;
-    var window = document.defaultView;
+    var document =
+        /** @type {!Document} */ (anchor instanceof Element ? anchor.ownerDocument : contentElement.ownerDocument);
+    var anchorBox = anchor instanceof AnchorBox ? anchor : anchor.boxInWindow();
+    this.setContentAnchorBox(anchorBox);
 
-    // Temporarily attach in order to measure preferred dimensions.
-    var preferredSize = view ? view.measurePreferredSize() : UI.measurePreferredSize(this._contentElement);
-    this._preferredWidth = preferredWidth || preferredSize.width;
-    this._preferredHeight = preferredHeight || preferredSize.height;
-
-    window.addEventListener('resize', this._hideBound, false);
-    document.body.appendChild(this._containerElement);
-    super.show(this._containerElement);
-
-    if (view)
-      view.show(this._contentDiv);
+    if (widget)
+      widget.show(this.contentElement);
     else
-      this._contentDiv.appendChild(this._contentElement);
+      this.contentElement.appendChild(contentElement);
 
-    this.positionElement(anchor, this._preferredWidth, this._preferredHeight);
+    super.show(document);
 
     if (this._popoverHelper) {
-      this._contentDiv.addEventListener(
+      this.contentElement.addEventListener(
           'mousemove', this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true);
-      this.element.addEventListener('mouseout', this._popoverHelper._popoverMouseOut.bind(this._popoverHelper), true);
+      this.contentElement.addEventListener(
+          'mouseout', this._popoverHelper._popoverMouseOut.bind(this._popoverHelper), true);
     }
   }
 
-  hide() {
-    this._containerElement.ownerDocument.defaultView.removeEventListener('resize', this._hideBound, false);
-    this.detach();
-    this._containerElement.remove();
-    delete UI.Popover._popover;
-  }
-
   /**
-   * @param {boolean} canShrink
+   * @override
    */
-  setCanShrink(canShrink) {
-    this._hasFixedHeight = !canShrink;
+  hide() {
+    super.hide();
+    delete UI.Popover._popover;
   }
 
   /**
    * @param {boolean} noPadding
    */
   setNoPadding(noPadding) {
-    this._hasNoPadding = noPadding;
-    this._contentDiv.classList.toggle('no-padding', this._hasNoPadding);
-  }
-
-  /**
-   * @param {!Element|!AnchorBox} anchorElement
-   * @param {number=} preferredWidth
-   * @param {number=} preferredHeight
-   */
-  positionElement(anchorElement, preferredWidth, preferredHeight) {
-    const borderWidth = this._hasNoPadding ? 0 : 8;
-    const scrollerWidth = this._hasFixedHeight ? 0 : 14;
-    const arrowHeight = this._hasNoPadding ? 8 : 15;
-    const arrowOffset = 10;
-    const borderRadius = 4;
-    const arrowRadius = 6;
-    preferredWidth = preferredWidth || this._preferredWidth;
-    preferredHeight = preferredHeight || this._preferredHeight;
-
-    // Skinny tooltips are not pretty, their arrow location is not nice.
-    preferredWidth = Math.max(preferredWidth, 50);
-    // Position relative to main DevTools element.
-    const container = UI.GlassPane.container(/** @type {!Document} */ (this._containerElement.ownerDocument));
-    const totalWidth = container.offsetWidth;
-    const totalHeight = container.offsetHeight;
-
-    var anchorBox = anchorElement instanceof AnchorBox ? anchorElement : anchorElement.boxInWindow(window);
-    anchorBox = anchorBox.relativeToElement(container);
-    var newElementPosition = {x: 0, y: 0, width: preferredWidth + scrollerWidth, height: preferredHeight};
-
-    var arrowAtBottom;
-    var roomAbove = anchorBox.y;
-    var roomBelow = totalHeight - anchorBox.y - anchorBox.height;
-    this._popupArrowElement.hidden = false;
-
-    if (roomAbove > roomBelow) {
-      // Positioning above the anchor.
-      if (anchorBox.y > newElementPosition.height + arrowHeight + borderRadius) {
-        newElementPosition.y = anchorBox.y - newElementPosition.height - arrowHeight;
-      } else {
-        this._popupArrowElement.hidden = true;
-        newElementPosition.y = borderRadius;
-        newElementPosition.height = anchorBox.y - borderRadius * 2 - arrowHeight;
-        if (this._hasFixedHeight && newElementPosition.height < preferredHeight) {
-          newElementPosition.y = borderRadius;
-          newElementPosition.height = preferredHeight;
-        }
-      }
-      arrowAtBottom = true;
-    } else {
-      // Positioning below the anchor.
-      newElementPosition.y = anchorBox.y + anchorBox.height + arrowHeight;
-      if (newElementPosition.y + newElementPosition.height + borderRadius >= totalHeight) {
-        this._popupArrowElement.hidden = true;
-        newElementPosition.height = totalHeight - borderRadius - newElementPosition.y;
-        if (this._hasFixedHeight && newElementPosition.height < preferredHeight) {
-          newElementPosition.y = totalHeight - preferredHeight - borderRadius;
-          newElementPosition.height = preferredHeight;
-        }
-      }
-      // Align arrow.
-      arrowAtBottom = false;
-    }
-
-    var arrowAtLeft;
-    this._popupArrowElement.removeAttribute('style');
-    if (anchorBox.x + newElementPosition.width < totalWidth) {
-      newElementPosition.x = Math.max(borderRadius, anchorBox.x - borderRadius - arrowOffset);
-      arrowAtLeft = true;
-      this._popupArrowElement.style.left = arrowOffset + 'px';
-    } else if (newElementPosition.width + borderRadius * 2 < totalWidth) {
-      newElementPosition.x = totalWidth - newElementPosition.width - borderRadius - 2 * borderWidth;
-      arrowAtLeft = false;
-      // Position arrow accurately.
-      var arrowRightPosition = Math.max(0, totalWidth - anchorBox.x - anchorBox.width - borderRadius - arrowOffset);
-      arrowRightPosition += anchorBox.width / 2;
-      arrowRightPosition = Math.min(arrowRightPosition, newElementPosition.width - borderRadius - arrowOffset);
-      this._popupArrowElement.style.right = arrowRightPosition + 'px';
-    } else {
-      newElementPosition.x = borderRadius;
-      newElementPosition.width = totalWidth - borderRadius * 2;
-      newElementPosition.height += scrollerWidth;
-      arrowAtLeft = true;
-      if (arrowAtBottom)
-        newElementPosition.y -= scrollerWidth;
-      // Position arrow accurately.
-      this._popupArrowElement.style.left =
-          Math.max(0, anchorBox.x - newElementPosition.x - borderRadius - arrowRadius + anchorBox.width / 2) + 'px';
-    }
-
-    this._popupArrowElement.className =
-        `arrow ${(arrowAtBottom ? 'bottom' : 'top')}-${(arrowAtLeft ? 'left' : 'right')}-arrow`;
-    this.element.positionAt(newElementPosition.x, newElementPosition.y - borderWidth, container);
-    this.element.style.width = newElementPosition.width + borderWidth * 2 + 'px';
-    this.element.style.height = newElementPosition.height + borderWidth * 2 + 'px';
+    // TODO(dgozman): remove this. Clients should add padding themselves.
+    this.contentElement.classList.toggle('no-padding', noPadding);
   }
 };
 
@@ -294,7 +178,7 @@ UI.PopoverHelper = class {
   _popoverMouseOut(event) {
     if (!this.isPopoverVisible())
       return;
-    if (event.relatedTarget && !event.relatedTarget.isSelfOrDescendant(this._popover._contentDiv))
+    if (event.relatedTarget && !event.relatedTarget.isSelfOrDescendant(this._popover.contentElement))
       this._startHidePopoverTimer();
   }