third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js - Issue 2712063002: [DevTools] Migrate Popover to GlassPane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

Issue 2712063002: [DevTools] Migrate Popover to GlassPane (Closed)

Patch Set: nit Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/objectPopover.css ('k') | third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

index bfc5cd0a5f8a4e44290d3f79e68996e9a6d5cb61..f3e5010b51a96d5c091eee59b8a7504545f26b4f 100644

--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

@@ -112,7 +112,7 @@ PerfUI.TimelineOverviewPane = class extends UI.VBox {

if (!this._popover)

return;

this._buildPopoverContents().then(updatePopover.bind(this));

- this._popover.positionElement(this._cursorElement);

+ this._popover.setContentAnchorBox(this._cursorElement.boxInWindow());

/**

* @param {!DocumentFragment} fragment