[inspector] added restrictToFunction flag for getPossibleBreakpoints

[inspector] added restrictToFunction flag for getPossibleBreakpoints

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2710953004
Cr-Commit-Position: refs/heads/master@{#43457}
Committed: https://chromium.googlesource.com/v8/v8/+/4d7fa10c2bb08343417e448208976ab63cac08c6

[kozy, 2017-02-22 23:04:47]

Dmitry and Yang, please take a look.

[dgozman, 2017-02-22 23:20:39]

lgtm

https://codereview.chromium.org/2710953004/diff/1/src/inspector/js_protocol.json
File src/inspector/js_protocol.json (right):

https://codereview.chromium.org/2710953004/diff/1/src/inspector/js_protocol.j...
src/inspector/js_protocol.json:596: { "name": "ignoreNestedFunctions", "type":
"boolean", "optional": true, "description": "If true then nested functions in
the range are ignored." }
restrictToFunction

Only consider locations which are in the same (non-nested) function as start
location.

https://codereview.chromium.org/2710953004/diff/1/test/inspector/debugger/get...
File test/inspector/debugger/get-possible-breakpoints-ignore-nested-expected.txt
(right):

https://codereview.chromium.org/2710953004/diff/1/test/inspector/debugger/get...
test/inspector/debugger/get-possible-breakpoints-ignore-nested-expected.txt:62:
nested1 (test.js:4:4)
Stepping...

[kozy, 2017-02-22 23:23:41]

Description was changed from

==========
[inspector] added ignore nested functions flag for getPossibleBreakpoints

BUG=none
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] added ignore nested functions flag for getPossibleBreakpoints

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org
==========

[kozy, 2017-02-22 23:43:50]

all done.

https://codereview.chromium.org/2710953004/diff/1/src/inspector/js_protocol.json
File src/inspector/js_protocol.json (right):

https://codereview.chromium.org/2710953004/diff/1/src/inspector/js_protocol.j...
src/inspector/js_protocol.json:596: { "name": "ignoreNestedFunctions", "type":
"boolean", "optional": true, "description": "If true then nested functions in
the range are ignored." }
On 2017/02/22 23:20:39, dgozman wrote:
> restrictToFunction
> 
> Only consider locations which are in the same (non-nested) function as start
> location.

Done.

https://codereview.chromium.org/2710953004/diff/1/test/inspector/debugger/get...
File test/inspector/debugger/get-possible-breakpoints-ignore-nested-expected.txt
(right):

https://codereview.chromium.org/2710953004/diff/1/test/inspector/debugger/get...
test/inspector/debugger/get-possible-breakpoints-ignore-nested-expected.txt:62:
nested1 (test.js:4:4)
On 2017/02/22 23:20:39, dgozman wrote:
> Stepping...

Done.

[kozy, 2017-02-22 23:44:10]

Description was changed from

==========
[inspector] added ignore nested functions flag for getPossibleBreakpoints

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] added restrictToFunction flag for getPossibleBreakpoints

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org
==========

[kozy, 2017-02-24 20:05:30]

Yang, please take a look on debug.cc changes.

[Yang, 2017-02-27 13:10:30]

lgtm

[kozy, 2017-02-27 16:24:01]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-27 16:24:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2710953004/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-27 16:24:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 16:53:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488212641344020,
"parent_rev": "7d1d83e52561e287c334143a9d110916dfc5998e", "commit_rev":
"4d7fa10c2bb08343417e448208976ab63cac08c6"}

[commit-bot: I haz the power, 2017-02-27 16:53:09]

Description was changed from

==========
[inspector] added restrictToFunction flag for getPossibleBreakpoints

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] added restrictToFunction flag for getPossibleBreakpoints

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2710953004
Cr-Commit-Position: refs/heads/master@{#43457}
Committed:
https://chromium.googlesource.com/v8/v8/+/4d7fa10c2bb08343417e448208976ab63ca...
==========

[commit-bot: I haz the power, 2017-02-27 16:53:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4d7fa10c2bb08343417e448208976ab63ca...