[inspector] use BREAK_POSITION_ALIGNED for breakpoints

[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2709263002
Cr-Original-Commit-Position: refs/heads/master@{#43385}
Committed: https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b6ccf0
Review-Url: https://codereview.chromium.org/2709263002
Cr-Commit-Position: refs/heads/master@{#43400}
Committed: https://chromium.googlesource.com/v8/v8/+/59eb62d48303bb15561b1b8f3e8fa1e53b3cc9e6

[kozy, 2017-02-22 17:28:11]

Dmitry and Yang, please take a look!

[Yang, 2017-02-22 19:27:03]

https://codereview.chromium.org/2709263002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2709263002/diff/1/src/debug/debug.cc#newcode1380
src/debug/debug.cc:1380: BREAK_POSITION_ALIGNED, positions);
Can you check whether we need to distinguish between these alignment at all
anymore? My impression is that we can get rid of this enum.

[Yang, 2017-02-22 19:27:11]

On 2017/02/22 19:27:03, Yang wrote:
> https://codereview.chromium.org/2709263002/diff/1/src/debug/debug.cc
> File src/debug/debug.cc (right):
> 
>
https://codereview.chromium.org/2709263002/diff/1/src/debug/debug.cc#newcode1380
> src/debug/debug.cc:1380: BREAK_POSITION_ALIGNED, positions);
> Can you check whether we need to distinguish between these alignment at all
> anymore? My impression is that we can get rid of this enum.

lgtm otherwise

[kozy, 2017-02-22 22:34:58]

Dmitry, please take a look.

I changed test expectations and upload expectations without CL as patchset
number 2.

Yang, as discussed offline, we still user STATEMENT_ALIGNED for debugger context
API.

[dgozman, 2017-02-22 23:13:11]

lgtm

[kozy, 2017-02-22 23:23:27]

Description was changed from

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=none
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org
==========

[kozy, 2017-02-22 23:28:12]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-22 23:28:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2709263002/#ps100001
(title: "| -> ^")

[commit-bot: I haz the power, 2017-02-22 23:28:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-02-22 23:41:02]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-22 23:41:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2709263002/#ps120001
(title: "little testcfg tuning")

[commit-bot: I haz the power, 2017-02-22 23:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:05:27]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487806862952560,
"parent_rev": "18e4c46de5c5269ed1a23219a9cefbd7d3a2a449", "commit_rev":
"2fed7a0090b316d77ebbf509d2cc98edd4b6ccf0"}

[commit-bot: I haz the power, 2017-02-23 00:05:32]

Description was changed from

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2709263002
Cr-Commit-Position: refs/heads/master@{#43385}
Committed:
https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b...
==========

[commit-bot: I haz the power, 2017-02-23 00:05:33]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b...

[Michael Achenbach, 2017-02-23 20:26:44]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2709313003/ by machenbach@chromium.org.

The reason for reverting is: breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

which blocks rolling. See also:
https://github.com/v8/v8/wiki/Blink-layout-tests.

[kozy, 2017-02-24 01:37:54]

Description was changed from

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2709263002
Cr-Commit-Position: refs/heads/master@{#43385}
Committed:
https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b...
==========

to

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2709263002
Cr-Commit-Position: refs/heads/master@{#43385}
Committed:
https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b...
==========

[kozy, 2017-02-24 01:38:20]

Failed test was better disabled, so try to reland..

[kozy, 2017-02-24 01:38:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-24 01:38:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 02:01:27]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487900304545430,
"parent_rev": "2375dfe06cd6c952d71790de7bb30ead1bd55f95", "commit_rev":
"59eb62d48303bb15561b1b8f3e8fa1e53b3cc9e6"}

[commit-bot: I haz the power, 2017-02-24 02:01:32]

Description was changed from

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2709263002
Cr-Commit-Position: refs/heads/master@{#43385}
Committed:
https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b...
==========

to

==========
[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned
breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2709263002
Cr-Original-Commit-Position: refs/heads/master@{#43385}
Committed:
https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b...
Review-Url: https://codereview.chromium.org/2709263002
Cr-Commit-Position: refs/heads/master@{#43400}
Committed:
https://chromium.googlesource.com/v8/v8/+/59eb62d48303bb15561b1b8f3e8fa1e53b3...
==========

[commit-bot: I haz the power, 2017-02-24 02:01:33]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/59eb62d48303bb15561b1b8f3e8fa1e53b3...