Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: src/inspector/v8-debugger-script.cc

Issue 2710953004: [inspector] added restrictToFunction flag for getPossibleBreakpoints (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-debugger-script.cc
diff --git a/src/inspector/v8-debugger-script.cc b/src/inspector/v8-debugger-script.cc
index 200cdc71a26da41ae8bba76d30144ad5a2eca0f7..4a5d5a1df0322c81bd282759ea2e2055d1ca9522 100644
--- a/src/inspector/v8-debugger-script.cc
+++ b/src/inspector/v8-debugger-script.cc
@@ -172,10 +172,12 @@ class ActualScript : public V8DebuggerScript {
bool getPossibleBreakpoints(
const v8::debug::Location& start, const v8::debug::Location& end,
+ bool restrictToFunction,
std::vector<v8::debug::Location>* locations) override {
v8::HandleScope scope(m_isolate);
v8::Local<v8::debug::Script> script = m_script.Get(m_isolate);
- return script->GetPossibleBreakpoints(start, end, locations);
+ return script->GetPossibleBreakpoints(start, end, restrictToFunction,
+ locations);
}
void resetBlackboxedStateCache() override {
@@ -228,6 +230,7 @@ class WasmVirtualScript : public V8DebuggerScript {
bool getPossibleBreakpoints(
const v8::debug::Location& start, const v8::debug::Location& end,
+ bool restrictToFunction,
std::vector<v8::debug::Location>* locations) override {
v8::HandleScope scope(m_isolate);
v8::Local<v8::debug::Script> script = m_script.Get(m_isolate);
@@ -247,8 +250,8 @@ class WasmVirtualScript : public V8DebuggerScript {
scriptId(), v8ScriptId);
}
- bool success = script->GetPossibleBreakpoints(translatedStart,
- translatedEnd, locations);
+ bool success = script->GetPossibleBreakpoints(
+ translatedStart, translatedEnd, restrictToFunction, locations);
for (v8::debug::Location& loc : *locations) {
TranslateV8LocationToProtocolLocation(m_wasmTranslation, &loc, v8ScriptId,
scriptId());
« no previous file with comments | « src/inspector/v8-debugger-script.h ('k') | test/inspector/debugger/get-possible-breakpoints-restrict-to-function.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698