[inspector] added master test for break locations

[inspector] added master test for break locations

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2710903003
Cr-Commit-Position: refs/heads/master@{#43459}
Committed: https://chromium.googlesource.com/v8/v8/+/bbeb6dc15db9a51a08c7441f6baac0a8d51aee67

[kozy, 2017-02-23 00:33:42]

Dmitry, please feel free to propose any other exciting JS constructions.

[dgozman, 2017-02-23 02:03:29]

lgtm

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-test-expected.txt
(right):

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test-expected.txt:89: 1
+ 2;
We don't have a location here? Interesting. Let's add "a;" statement as well.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test-expected.txt:95:
#await Promise.resolve().then(() => #42#);
No locations before resolve and then?

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-test.js (right):

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:12: for (var a
of [1,2,3]) {
for (var a in {x:2})

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:25: function
nested1() {}
Let's do double-nested as well.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:26: function
nested2() { return 42; }
function nested3() { return; }

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:52: // do
Forgot about if and with constructions, and also generators.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:105: }
Let's also have something complex like

foo(boo1(), x++, --y, x => 2 * x, boo2())().a = await async2((a => 2 * a)(5));

[kozy, 2017-02-27 17:37:58]

please take another look.

addressed comments and reused source from step-into test:
https://codereview.chromium.org/2719763002/

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-test-expected.txt
(right):

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test-expected.txt:89: 1
+ 2;
On 2017/02/23 02:03:28, dgozman wrote:
> We don't have a location here? Interesting. Let's add "a;" statement as well.

Looks like issue, stepping will break before 1 + 2.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test-expected.txt:95:
#await Promise.resolve().then(() => #42#);
On 2017/02/23 02:03:28, dgozman wrote:
> No locations before resolve and then?

looks like issue too.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-test.js (right):

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:12: for (var a
of [1,2,3]) {
On 2017/02/23 02:03:29, dgozman wrote:
> for (var a in {x:2})

Done.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:25: function
nested1() {}
On 2017/02/23 02:03:29, dgozman wrote:
> Let's do double-nested as well.

Done.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:26: function
nested2() { return 42; }
On 2017/02/23 02:03:29, dgozman wrote:
> function nested3() { return; }

Done.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:52: // do
On 2017/02/23 02:03:29, dgozman wrote:
> Forgot about if and with constructions, and also generators.

Done.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:105: }
On 2017/02/23 02:03:29, dgozman wrote:
> Let's also have something complex like
> 
> foo(boo1(), x++, --y, x => 2 * x, boo2())().a = await async2((a => 2 * a)(5));

Done.

[dgozman, 2017-02-27 18:01:10]

lgtm

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-test.js (right):

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:105: }
On 2017/02/27 17:37:58, kozy wrote:
> On 2017/02/23 02:03:29, dgozman wrote:
> > Let's also have something complex like
> > 
> > foo(boo1(), x++, --y, x => 2 * x, boo2())().a = await async2((a => 2 *
a)(5));
> 
> Done.

Forgot about this or did I miss it?

https://codereview.chromium.org/2710903003/diff/90001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-expected.txt
(right):

https://codereview.chromium.org/2710903003/diff/90001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-expected.txt:221: //#
sourceURL=break-locations.js
Looks like a break position ;)

[kozy, 2017-02-27 18:54:19]

thanks, all done.

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-test.js (right):

https://codereview.chromium.org/2710903003/diff/70001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-test.js:105: }
On 2017/02/27 18:01:10, dgozman wrote:
> On 2017/02/27 17:37:58, kozy wrote:
> > On 2017/02/23 02:03:29, dgozman wrote:
> > > Let's also have something complex like
> > > 
> > > foo(boo1(), x++, --y, x => 2 * x, boo2())().a = await async2((a => 2 *
> a)(5));
> > 
> > Done.
> 
> Forgot about this or did I miss it?

lost during migration to test from step-into :( added back! behavior is strange,
root - strange behavior of generators, it lead to strange stepping inside of
async functions.

https://codereview.chromium.org/2710903003/diff/90001/test/inspector/debugger...
File test/inspector/debugger/get-possible-breakpoints-master-expected.txt
(right):

https://codereview.chromium.org/2710903003/diff/90001/test/inspector/debugger...
test/inspector/debugger/get-possible-breakpoints-master-expected.txt:221: //#
sourceURL=break-locations.js
On 2017/02/27 18:01:10, dgozman wrote:
> Looks like a break position ;)

removed sourceURL comments.

[kozy, 2017-02-27 19:57:45]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-27 19:57:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2710903003/#ps110001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-27 19:57:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:20:40]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1488225465606130,
"parent_rev": "c63e83c1e97d4605ab3499828b0a9f0e88f90ac2", "commit_rev":
"bbeb6dc15db9a51a08c7441f6baac0a8d51aee67"}

[commit-bot: I haz the power, 2017-02-27 20:20:44]

Description was changed from

==========
[inspector] added master test for break locations

BUG=none
R=dgozman@chromium.org
==========

to

==========
[inspector] added master test for break locations

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2710903003
Cr-Commit-Position: refs/heads/master@{#43459}
Committed:
https://chromium.googlesource.com/v8/v8/+/bbeb6dc15db9a51a08c7441f6baac0a8d51...
==========

[commit-bot: I haz the power, 2017-02-27 20:20:45]

Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/v8/v8/+/bbeb6dc15db9a51a08c7441f6baac0a8d51...