Remove the touch ack timeout handler out of the legacy touch event queue.

Remove the touch ack timeout handler out of the legacy touch event queue.

This class needs to be re-used for the new touch event queue. So extract
the code out to a separate class (it was already an internal class) so
just move it into a separate file.

BUG=642368
TBR=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2709813002
Cr-Commit-Position: refs/heads/master@{#452054}
Committed: https://chromium.googlesource.com/chromium/src/+/48fd5b949faacbd387904d9844283bfcf1fe837a

[dtapuska, 2017-02-21 15:00:14]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:00:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:14:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:14:48]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[dtapuska, 2017-02-21 15:52:53]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:53:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:28:02]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2017-02-21 17:49:11]

Description was changed from

==========
Remove the touch ack timeout handler out of the legacy touch event queue.

This class needs to be re-used for the new touch event queue. So extract
the code out to a separate class (it was already an internal class) so
just move it into a separate file.

BUG=642368
==========

to

==========
Remove the touch ack timeout handler out of the legacy touch event queue.

This class needs to be re-used for the new touch event queue. So extract
the code out to a separate class (it was already an internal class) so
just move it into a separate file.

BUG=642368
==========

[dtapuska, 2017-02-21 17:49:11]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2017-02-21 18:16:31]

LGTM, modulo some nits about requires / forward declarations.

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/legacy_touch_event_queue.h (right):

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/legacy_touch_event_queue.h:27: class
TouchTimeoutHandler;
Why are we forward declaring this?

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/touch_timeout_handler.h (right):

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_timeout_handler.h:23: #include
"ui/gfx/geometry/point_f.h"
At least this include is unnecessary. Are there other unnecessary ones as well?

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_timeout_handler.h:27: class
TouchEventQueue;
We're including this and forward declaring it currently.

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_timeout_handler.h:46: private:
DISALLOW_COPY_AND_ASSIGN?

[dtapuska, 2017-02-21 18:26:47]

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/legacy_touch_event_queue.h (right):

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/legacy_touch_event_queue.h:27: class
TouchTimeoutHandler;
On 2017/02/21 18:16:31, tdresser wrote:
> Why are we forward declaring this?

Because there is an instance ptr in this class.

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/touch_timeout_handler.h (right):

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_timeout_handler.h:23: #include
"ui/gfx/geometry/point_f.h"
On 2017/02/21 18:16:31, tdresser wrote:
> At least this include is unnecessary. Are there other unnecessary ones as
well?

Done.

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_timeout_handler.h:27: class
TouchEventQueue;
On 2017/02/21 18:16:31, tdresser wrote:
> We're including this and forward declaring it currently.

Done.

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_timeout_handler.h:46: private:
On 2017/02/21 18:16:31, tdresser wrote:
> DISALLOW_COPY_AND_ASSIGN?

Done.

[tdresser, 2017-02-21 18:27:21]

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/legacy_touch_event_queue.h (right):

https://codereview.chromium.org/2709813002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/legacy_touch_event_queue.h:27: class
TouchTimeoutHandler;
On 2017/02/21 18:26:47, dtapuska wrote:
> On 2017/02/21 18:16:31, tdresser wrote:
> > Why are we forward declaring this?
> 
> Because there is an instance ptr in this class.

Acknowledged.

[dtapuska, 2017-02-21 18:27:41]

dtapuska@chromium.org changed reviewers:
+ clamy@chromium.org

[dtapuska, 2017-02-21 18:27:41]

clamy@chromium.org: Please review changes in 

BUILD.gn

[dtapuska, 2017-02-21 18:27:58]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 18:28:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 20:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:14:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dtapuska, 2017-02-21 20:15:51]

Description was changed from

==========
Remove the touch ack timeout handler out of the legacy touch event queue.

This class needs to be re-used for the new touch event queue. So extract
the code out to a separate class (it was already an internal class) so
just move it into a separate file.

BUG=642368
==========

to

==========
Remove the touch ack timeout handler out of the legacy touch event queue.

This class needs to be re-used for the new touch event queue. So extract
the code out to a separate class (it was already an internal class) so
just move it into a separate file.

BUG=642368
TBR=clamy@chromium.org
==========

[dtapuska, 2017-02-21 21:22:27]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2017-02-21 21:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2709813002/#ps40001
(title: "Fix nits")

[commit-bot: I haz the power, 2017-02-21 21:23:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:58:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[dtapuska, 2017-02-22 03:46:02]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:47:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 04:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:42:37]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[dtapuska, 2017-02-22 14:22:51]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-02-22 14:23:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 15:16:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487773371102440,
"parent_rev": "62f93ee9df19a59eef6c36632fc0035bfd0f4247", "commit_rev":
"48fd5b949faacbd387904d9844283bfcf1fe837a"}

[commit-bot: I haz the power, 2017-02-22 15:16:44]

Description was changed from

==========
Remove the touch ack timeout handler out of the legacy touch event queue.

This class needs to be re-used for the new touch event queue. So extract
the code out to a separate class (it was already an internal class) so
just move it into a separate file.

BUG=642368
TBR=clamy@chromium.org
==========

to

==========
Remove the touch ack timeout handler out of the legacy touch event queue.

This class needs to be re-used for the new touch event queue. So extract
the code out to a separate class (it was already an internal class) so
just move it into a separate file.

BUG=642368
TBR=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2709813002
Cr-Commit-Position: refs/heads/master@{#452054}
Committed:
https://chromium.googlesource.com/chromium/src/+/48fd5b949faacbd387904d984428...
==========

[commit-bot: I haz the power, 2017-02-22 15:16:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/48fd5b949faacbd387904d984428...

[clamy, 2017-02-22 16:40:52]

GN change lgtm.