Merging of touch event ack ids was inconsistent.

Merging of touch event ack ids was inconsistent.

The merging of event ids was slightly off that the ack type would be
sent for the wrong type. The newly merged dispatch type should reflect
the type of the ack event id. ie; if 17 was non-blocking it should
continue as non-blocking not be 17 and have type blocking afterwards.

BUG=642368
Review-Url: https://codereview.chromium.org/2710663003
Cr-Commit-Position: refs/heads/master@{#452183}
Committed: https://chromium.googlesource.com/chromium/src/+/ec3a4f60b7c9ca26b32424abe1fc0c238eee739b

[dtapuska, 2017-02-21 16:54:06]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 16:54:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:41:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtapuska, 2017-02-21 18:35:39]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 18:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 20:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:38:45]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[dtapuska, 2017-02-22 15:23:42]

Description was changed from

==========
Merging of touch event ack ids was inconsistent.

The merging of event ids was slightly off that the ack type would be
sent for the wrong type. The newly merged dispatch type should reflect
the type of the ack event id. ie; if 17 was non-blocking it should
continue as non-blocking not be 17 and have type blocking afterwards.

BUG=642368
==========

to

==========
Merging of touch event ack ids was inconsistent.

The merging of event ids was slightly off that the ack type would be
sent for the wrong type. The newly merged dispatch type should reflect
the type of the ack event id. ie; if 17 was non-blocking it should
continue as non-blocking not be 17 and have type blocking afterwards.

BUG=642368
==========

[dtapuska, 2017-02-22 15:23:42]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2017-02-22 15:53:47]

LGTM with nit.

https://codereview.chromium.org/2710663003/diff/20001/content/renderer/input/...
File content/renderer/input/main_thread_event_queue.cc (right):

https://codereview.chromium.org/2710663003/diff/20001/content/renderer/input/...
content/renderer/input/main_thread_event_queue.cc:44: void
EventWithDispatchType::CoalesceWith(const EventWithDispatchType& other) {
This method doesn't make it super clear whether you coalesce a newer event into
an older event, or an older event into a newer event, which I think is where
this confusion came from originally.

Can we add a comment indicating which is correct, and DCHECK that the timestamps
are valid?

[dtapuska, 2017-02-22 18:43:48]

https://codereview.chromium.org/2710663003/diff/20001/content/renderer/input/...
File content/renderer/input/main_thread_event_queue.cc (right):

https://codereview.chromium.org/2710663003/diff/20001/content/renderer/input/...
content/renderer/input/main_thread_event_queue.cc:44: void
EventWithDispatchType::CoalesceWith(const EventWithDispatchType& other) {
On 2017/02/22 15:53:47, tdresser wrote:
> This method doesn't make it super clear whether you coalesce a newer event
into
> an older event, or an older event into a newer event, which I think is where
> this confusion came from originally.
> 
> Can we add a comment indicating which is correct, and DCHECK that the
timestamps
> are valid?

The ScopedWebInputEventWithLatencyInfo already DCHECKS that the tracing id of
"other" is after "this" one; but I will add a comment.

[dtapuska, 2017-02-22 18:43:58]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2017-02-22 18:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2710663003/#ps40001
(title: "Add comment")

[commit-bot: I haz the power, 2017-02-22 18:44:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:21:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487789038662430,
"parent_rev": "d77665828c121ae807d0b6dd28880695baa9d9e6", "commit_rev":
"ec3a4f60b7c9ca26b32424abe1fc0c238eee739b"}

[commit-bot: I haz the power, 2017-02-22 20:23:19]

Description was changed from

==========
Merging of touch event ack ids was inconsistent.

The merging of event ids was slightly off that the ack type would be
sent for the wrong type. The newly merged dispatch type should reflect
the type of the ack event id. ie; if 17 was non-blocking it should
continue as non-blocking not be 17 and have type blocking afterwards.

BUG=642368
==========

to

==========
Merging of touch event ack ids was inconsistent.

The merging of event ids was slightly off that the ack type would be
sent for the wrong type. The newly merged dispatch type should reflect
the type of the ack event id. ie; if 17 was non-blocking it should
continue as non-blocking not be 17 and have type blocking afterwards.

BUG=642368

Review-Url: https://codereview.chromium.org/2710663003
Cr-Commit-Position: refs/heads/master@{#452183}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec3a4f60b7c9ca26b32424abe1fc...
==========

[commit-bot: I haz the power, 2017-02-22 20:23:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ec3a4f60b7c9ca26b32424abe1fc...