Expand FrameSeleciton::isContentEditable() to increase chances of hoisting update layout

Expand FrameSeleciton::isContentEditable() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isContentEditable()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isContentEditable()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isContentEditable()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709503003
Cr-Commit-Position: refs/heads/master@{#451959}
Committed: https://chromium.googlesource.com/chromium/src/+/a68600309d39180eda0c6f30be56058dabe2d8c8

[yosin_UTC9, 2017-02-21 06:52:09]

Description was changed from

==========
2017-02-21T15:51:00

2017-02-21T15:50:49

BUG=
==========

to

==========
Expand FrameSeleciton::rootEditableElement()  to increase chances of hoisting
update layout

This patch expands |FrameSeleciton::rootEditableElement()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().rootEditableElement()|
by
|selection().computeVisibleSelectionInDOMTreeDeprecated().rootEditableElement()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 06:52:51]

Description was changed from

==========
Expand FrameSeleciton::rootEditableElement()  to increase chances of hoisting
update layout

This patch expands |FrameSeleciton::rootEditableElement()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().rootEditableElement()|
by
|selection().computeVisibleSelectionInDOMTreeDeprecated().rootEditableElement()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::isContentEditable() to increase chances of hoisting
update layout

This patch expands |FrameSeleciton::isContentEditable()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isContentEditable()|
by
|selection().computeVisibleSelectionInDOMTreeDeprecated().isContentEditable()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 06:53:15]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 06:53:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 08:13:22]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-21 08:13:23]

PTAL

Changes in core/editing/, core/page/ and core/svg

[tkent, 2017-02-21 08:27:07]

lgtm

[commit-bot: I haz the power, 2017-02-21 09:43:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 09:43:23]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2017-02-21 12:29:30]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 12:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 13:10:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 13:10:39]

Failed to apply patch for
third_party/WebKit/Source/core/page/DragController.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/page/DragController.cpp:1139
  error: third_party/WebKit/Source/core/page/DragController.cpp: patch does not
apply

Patch:       third_party/WebKit/Source/core/page/DragController.cpp
Index: third_party/WebKit/Source/core/page/DragController.cpp
diff --git a/third_party/WebKit/Source/core/page/DragController.cpp
b/third_party/WebKit/Source/core/page/DragController.cpp
index
3ffdd07b1cb777aeb7d62b2fed3220872f9e27f0..5b6367c914edee6f41df746083ce961744454122
100644
--- a/third_party/WebKit/Source/core/page/DragController.cpp
+++ b/third_party/WebKit/Source/core/page/DragController.cpp
@@ -199,8 +199,9 @@ static DocumentFragment* documentFragmentFromDragData(
 
 bool DragController::dragIsMove(FrameSelection& selection, DragData* dragData)
{
   return m_documentUnderMouse == m_dragInitiator &&
-         selection.isContentEditable() && selection.isRange() &&
-         !isCopyKeyDown(dragData);
+         selection.computeVisibleSelectionInDOMTreeDeprecated()
+             .isContentEditable() &&
+         selection.isRange() && !isCopyKeyDown(dragData);
 }
 
 // FIXME: This method is poorly named.  We're just clearing the selection from
@@ -478,7 +479,10 @@ static bool setSelectionToDragCaret(LocalFrame* frame,
     dragCaret =
frame->selection().computeVisibleSelectionInDOMTreeDeprecated();
     range = createRange(dragCaret.toNormalizedEphemeralRange());
   }
-  return !frame->selection().isNone() &&
frame->selection().isContentEditable();
+  return !frame->selection().isNone() &&
+         frame->selection()
+             .computeVisibleSelectionInDOMTreeDeprecated()
+             .isContentEditable();
 }
 
 DispatchEventResult DragController::dispatchTextInputEventFor(
@@ -1139,7 +1143,10 @@ bool DragController::startDrag(LocalFrame* src,
   } else if (state.m_dragType == DragSourceActionLink) {
     if (linkURL.isEmpty())
       return false;
-    if (src->selection().isCaret() && src->selection().isContentEditable()) {
+    if (src->selection().isCaret() &&
+        src->selection()
+            .computeVisibleSelectionInDOMTreeDeprecated()
+            .isContentEditable()) {
       // a user can initiate a drag on a link without having any text
       // selected.  In this case, we should expand the selection to
       // the enclosing anchor element

[yosin_UTC9, 2017-02-21 23:13:31]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 23:14:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 23:43:58]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-21 23:44:01]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-02-21 23:44:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2709503003/#ps20001
(title: "2017-02-22T08:13:55 rebase")

[commit-bot: I haz the power, 2017-02-21 23:44:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:19:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:19:20]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[yosin_UTC9, 2017-02-22 01:44:13]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:46:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:49:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[yosin_UTC9, 2017-02-22 02:10:16]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:11:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:48:14]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[yosin_UTC9, 2017-02-22 03:53:59]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:55:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 04:42:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:42:33]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[yosin_UTC9, 2017-02-22 05:11:29]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-22 05:12:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 07:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:52:37]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-02-22 07:59:22]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-22 08:00:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 09:47:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487750362841060,
"parent_rev": "e4813d56655ddf9f7d85e4b8985c7011d99898ce", "commit_rev":
"a68600309d39180eda0c6f30be56058dabe2d8c8"}

[commit-bot: I haz the power, 2017-02-22 09:48:40]

Description was changed from

==========
Expand FrameSeleciton::isContentEditable() to increase chances of hoisting
update layout

This patch expands |FrameSeleciton::isContentEditable()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isContentEditable()|
by
|selection().computeVisibleSelectionInDOMTreeDeprecated().isContentEditable()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::isContentEditable() to increase chances of hoisting
update layout

This patch expands |FrameSeleciton::isContentEditable()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isContentEditable()|
by
|selection().computeVisibleSelectionInDOMTreeDeprecated().isContentEditable()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709503003
Cr-Commit-Position: refs/heads/master@{#451959}
Committed:
https://chromium.googlesource.com/chromium/src/+/a68600309d39180eda0c6f30be56...
==========

[commit-bot: I haz the power, 2017-02-22 09:48:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a68600309d39180eda0c6f30be56...