third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 2709503003: Expand FrameSeleciton::isContentEditable() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2709503003: Expand FrameSeleciton::isContentEditable() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-22T08:13:55 rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index b86f321e6825c21e7b25208f388718d8277954bf..b4cff0c3f69c229e8888bb86fa2bf2d1f5477a4d 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -1942,7 +1942,9 @@ static bool enabledRangeInEditableText(LocalFrame& frame,

return frame.selection()

.computeVisibleSelectionInDOMTreeDeprecated()

.isRange() &&

- frame.selection().isContentEditable();

+ frame.selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .isContentEditable();

}

static bool enabledRangeInRichlyEditableText(LocalFrame& frame,