Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2709503003: Expand FrameSeleciton::isContentEditable() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-22T08:13:55 rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index 88d9742d6b0a20624fd5ed11e354f739d06c5463..3db73c6b39660ba2cfaca50c5f90ced80d123c38 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -987,7 +987,9 @@ void SelectionController::sendContextMenuEvent(
// If the selection is non-editable, we do word selection to make it
// easier to use the contextual menu items available for text selections.
// But only if we're above text.
- !(selection().isContentEditable() ||
+ !(selection()
+ .computeVisibleSelectionInDOMTreeDeprecated()
+ .isContentEditable() ||
(mev.innerNode() && mev.innerNode()->isTextNode())))
return;

Powered by Google App Engine
This is Rietveld 408576698