Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2709503003: Expand FrameSeleciton::isContentEditable() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-22T08:13:55 rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Editor.cpp
diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp
index 5a50facd29f34cfd7e38e20e0632135d5b042c34..eca9cfba108274da10c30bb9f000962a4537ed8e 100644
--- a/third_party/WebKit/Source/core/editing/Editor.cpp
+++ b/third_party/WebKit/Source/core/editing/Editor.cpp
@@ -605,7 +605,11 @@ void Editor::replaceSelectionWithFragment(DocumentFragment* fragment,
InputEvent::InputType inputType) {
DCHECK(!frame().document()->needsLayoutTreeUpdate());
if (frame().selection().isNone() ||
- !frame().selection().isContentEditable() || !fragment)
+ !frame()
+ .selection()
+ .computeVisibleSelectionInDOMTreeDeprecated()
+ .isContentEditable() ||
+ !fragment)
return;
ReplaceSelectionCommand::CommandOptions options =
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698