[ObjC ARC] Converts ios/chrome/app/application_delegate:unit_tests to ARC.

[ObjC ARC] Converts ios/chrome/app/application_delegate:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2708683002
Cr-Commit-Position: refs/heads/master@{#451649}
Committed: https://chromium.googlesource.com/chromium/src/+/3c11a699a72530365fd73f6d880802d05d8bd2e8

[stkhapugin, 2017-02-20 14:37:12]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 14:37:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 15:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 15:31:07]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[stkhapugin, 2017-02-20 15:56:57]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2017-02-20 15:56:58]

ptal

[sdefresne, 2017-02-20 16:00:33]

lgtm

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/app_state_unittest.mm (right):

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/app_state_unittest.mm:167: } copy];
nit: you don't need to copy blocks with ARC

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/app_state_unittest.mm:291: //
TODO(crbug.com/585700): remove this.
I think this can be removed now. Can you do this as a follow-up CL?

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/user_activity_handler_unittest.mm
(right):

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/user_activity_handler_unittest.mm:50:
@property(copy, nonatomic, readonly) NSString* tabId;
please put "nonatomic" first

[stkhapugin, 2017-02-20 16:09:03]

thanks!

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/app_state_unittest.mm (right):

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/app_state_unittest.mm:167: } copy];
On 2017/02/20 16:00:33, sdefresne wrote:
> nit: you don't need to copy blocks with ARC

Done.

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/app_state_unittest.mm:291: //
TODO(crbug.com/585700): remove this.
On 2017/02/20 16:00:33, sdefresne wrote:
> I think this can be removed now. Can you do this as a follow-up CL?

I will try to remove this in a follow-up CL. However from the discussion on the
bug, this might not be straightforward, and if this is the case, I would like to
not do anything more than trying to remove this snippet.

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/user_activity_handler_unittest.mm
(right):

https://codereview.chromium.org/2708683002/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/user_activity_handler_unittest.mm:50:
@property(copy, nonatomic, readonly) NSString* tabId;
On 2017/02/20 16:00:33, sdefresne wrote:
> please put "nonatomic" first

Done.

[stkhapugin, 2017-02-20 16:16:31]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-02-20 16:16:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2708683002/#ps40001
(title: "fix compile")

[commit-bot: I haz the power, 2017-02-20 16:16:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 17:59:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487607391450080,
"parent_rev": "3e809d1f60ee19d1021842752704717001f1e0b4", "commit_rev":
"3c11a699a72530365fd73f6d880802d05d8bd2e8"}

[commit-bot: I haz the power, 2017-02-20 18:00:15]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/app/application_delegate:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/app/application_delegate:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2708683002
Cr-Commit-Position: refs/heads/master@{#451649}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c11a699a72530365fd73f6d8808...
==========

[commit-bot: I haz the power, 2017-02-20 18:00:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3c11a699a72530365fd73f6d8808...