Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2703183003: Remove the now-unnecessary RequestTracker in a unit test.

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes RequestTracker and related code. BUG=585700

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M ios/chrome/app/application_delegate/app_state_unittest.mm View 1 2 chunks +1 line, -37 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
stkhapugin
As promised, follow-up CL. PTAL
3 years, 10 months ago (2017-02-21 10:22:49 UTC) #7
sdefresne
lgtm https://codereview.chromium.org/2703183003/diff/1/ios/chrome/app/application_delegate/app_state_unittest.mm File ios/chrome/app/application_delegate/app_state_unittest.mm (right): https://codereview.chromium.org/2703183003/diff/1/ios/chrome/app/application_delegate/app_state_unittest.mm#newcode294 ios/chrome/app/application_delegate/app_state_unittest.mm:294: : thread_bundle_(web::TestWebThreadBundle::REAL_IO_THREAD) {} Can you try to not ...
3 years, 10 months ago (2017-02-21 10:40:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703183003/20001
3 years, 8 months ago (2017-04-07 15:31:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/189421)
3 years, 8 months ago (2017-04-07 16:23:11 UTC) #13
sdefresne
3 years, 6 months ago (2017-06-15 09:40:08 UTC) #18
On 2017/04/07 16:23:11, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

stkhapugin: ping?

Powered by Google App Engine
This is Rietveld 408576698