|
|
Created:
3 years, 10 months ago by stkhapugin Modified:
3 years, 6 months ago Reviewers:
sdefresne CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoves RequestTracker and related code.
BUG=585700
Patch Set 1 #
Total comments: 1
Patch Set 2 : comment #Messages
Total messages: 18 (13 generated)
Description was changed from ========== rebae# Enter a description of the change. git cl w# This will be displayed on the codereview site. Merge branch 'ios-chrome-app-application_delegate_unit_tests' into address_todos asdf BUG= ========== to ========== Removes RequestTracker and related code. BUG=585700 ==========
stkhapugin@chromium.org changed reviewers: + sdefresne@chromium.org
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
As promised, follow-up CL. PTAL
lgtm https://codereview.chromium.org/2703183003/diff/1/ios/chrome/app/application_... File ios/chrome/app/application_delegate/app_state_unittest.mm (right): https://codereview.chromium.org/2703183003/diff/1/ios/chrome/app/application_... ios/chrome/app/application_delegate/app_state_unittest.mm:294: : thread_bundle_(web::TestWebThreadBundle::REAL_IO_THREAD) {} Can you try to not pass web::TestWebThreadBundle::REAL_IO_THREAD to this constructor (i.e. use the default constructor)? I think it may work with default constructor which would avoid creating a real thread. If not, then we can go back to this version.
The CQ bit was checked by stkhapugin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2703183003/#ps20001 (title: "comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
On 2017/04/07 16:23:11, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) stkhapugin: ping? |