[ObjC ARC] Converts ios/chrome/app/application_delegate:unit_tests to ARC.

ios/chrome/app/application_delegate/app_state_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/app/application_delegate/app_state.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include "base/ios/block_types.h"
 #include "base/mac/scoped_block.h"
-#import "base/mac/scoped_nsobject.h"
 #include "base/memory/ptr_util.h"
 #include "base/synchronization/lock.h"
 #import "ios/chrome/app/application_delegate/app_navigation.h"
 #import "ios/chrome/app/application_delegate/app_state_testing.h"
 #import "ios/chrome/app/application_delegate/browser_launcher.h"
 #import "ios/chrome/app/application_delegate/fake_startup_information.h"
 #import "ios/chrome/app/application_delegate/memory_warning_helper.h"
 #import "ios/chrome/app/application_delegate/metrics_mediator.h"
 #import "ios/chrome/app/application_delegate/mock_tab_opener.h"
 #import "ios/chrome/app/application_delegate/startup_information.h"
@@ skipping 15 matching lines @@
 #include "ios/public/provider/chrome/browser/distribution/app_distribution_provider.h"
 #include "ios/public/provider/chrome/browser/test_chrome_browser_provider.h"
 #include "ios/public/provider/chrome/browser/user_feedback/test_user_feedback_provider.h"
 #import "ios/testing/ocmock_complex_type_helper.h"
 #include "ios/web/net/request_tracker_impl.h"
 #include "ios/web/public/test/test_web_thread_bundle.h"
 #include "testing/platform_test.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
 #include "third_party/ocmock/gtest_support.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 #pragma mark - Class definition.
 
 namespace {
 
 // A block that takes self as argument and return a BOOL.
 typedef BOOL (^DecisionBlock)(id self);
 // A block that takes the arguments of UserActivityHandler's
 // +handleStartupParametersWithTabOpener.
 typedef void (^HandleStartupParam)(
     id self,
@@ skipping 95 matching lines @@
   }
 
   void stubNullBrowserState(id BVC) {
     [[[BVC stub] andDo:^(NSInvocation* invocation) {
       ios::ChromeBrowserState* browserState = nullptr;
       [invocation setReturnValue:&browserState];
     }] browserState];
   }
 
   void swizzleSafeModeShouldStart(BOOL shouldStart) {
-    safe_mode_swizzle_block_.reset([^BOOL(id self) {
+    safe_mode_swizzle_block_ = ^BOOL(id self) {
       return shouldStart;
-    } copy]);
+    };
     safe_mode_swizzler_.reset(new ScopedBlockSwizzler(
         [SafeModeCoordinator class], @selector(shouldStart),
         safe_mode_swizzle_block_));
   }
 
   void swizzleMetricsMediatorDisableReporting() {
     metrics_mediator_called_ = NO;
 
-    metrics_mediator_swizzle_block_.reset([^(id self) {
+    metrics_mediator_swizzle_block_ = ^() {
       metrics_mediator_called_ = YES;
-    } copy]);
+    };
 
     metrics_mediator_swizzler_.reset(new ScopedBlockSwizzler(
         [MetricsMediator class], @selector(disableReporting),
         metrics_mediator_swizzle_block_));
   }
 
   void swizzleHandleStartupParameters(
       id<TabOpening> expectedTabOpener,
       id<BrowserViewInformation> expectedBrowserViewInformation) {
-    handle_startup_swizzle_block_.reset(
+    handle_startup_swizzle_block_ =
         ^(id self, id<TabOpening> tabOpener,
           id<StartupInformation> startupInformation,
           id<BrowserViewInformation> browserViewInformation) {
           ASSERT_EQ(startup_information_mock_, startupInformation);
           ASSERT_EQ(expectedTabOpener, tabOpener);
           ASSERT_EQ(expectedBrowserViewInformation, browserViewInformation);
-        },
-        base::scoped_policy::RETAIN);
+        };
 
     handle_startup_swizzler_.reset(new ScopedBlockSwizzler(
         [UserActivityHandler class],
         @selector(handleStartupParametersWithTabOpener:
                                     startupInformation:
                                 browserViewInformation:),
         handle_startup_swizzle_block_));
   }
 
   AppState* getAppStateWithOpenNTPAndIncognitoBlock(BOOL shouldOpenNTP,
@@ skipping 31 matching lines @@
                                    tabOpener:tabOpener
                                appNavigation:appNavigation];
 
     initializeIncognitoBlocker(window);
 
     return appState;
   }
 
   AppState* getAppStateWithMock() {
     if (!app_state_) {
-      app_state_.reset([[AppState alloc]
-          initWithBrowserLauncher:browser_launcher_mock_
-               startupInformation:startup_information_mock_
-              applicationDelegate:main_application_delegate_]);
+      app_state_ =
+          [[AppState alloc] initWithBrowserLauncher:browser_launcher_mock_
+                                 startupInformation:startup_information_mock_
+                                applicationDelegate:main_application_delegate_];
       [app_state_ setWindow:window_];
     }
     return app_state_;
   }
 
   AppState* getAppStateWithRealWindow(UIWindow* window) {
     if (!app_state_) {
-      app_state_.reset([[AppState alloc]
-          initWithBrowserLauncher:browser_launcher_mock_
-               startupInformation:startup_information_mock_
-              applicationDelegate:main_application_delegate_]);
+      app_state_ =
+          [[AppState alloc] initWithBrowserLauncher:browser_launcher_mock_
+                                 startupInformation:startup_information_mock_
+                                applicationDelegate:main_application_delegate_];
       [app_state_ setWindow:window];
     }
     return app_state_;
   }
 
   id getBrowserLauncherMock() { return browser_launcher_mock_; }
   id getStartupInformationMock() { return startup_information_mock_; }
   id getApplicationDelegateMock() { return main_application_delegate_; }
   id getWindowMock() { return window_; }
   id getBrowserViewInformationMock() { return browser_view_information_; }
 
   BOOL metricsMediatorHasBeenCalled() { return metrics_mediator_called_; }
 
  private:
-  base::scoped_nsobject<AppState> app_state_;
+  AppState* app_state_;
   id browser_launcher_mock_;
   id startup_information_mock_;
   id main_application_delegate_;
   id window_;
   id browser_view_information_;
-  base::mac::ScopedBlock<DecisionBlock> safe_mode_swizzle_block_;
-  base::mac::ScopedBlock<HandleStartupParam> handle_startup_swizzle_block_;
-  base::mac::ScopedBlock<ProceduralBlock> metrics_mediator_swizzle_block_;
+  DecisionBlock safe_mode_swizzle_block_;
+  HandleStartupParam handle_startup_swizzle_block_;
+  ProceduralBlock metrics_mediator_swizzle_block_;
   std::unique_ptr<ScopedBlockSwizzler> safe_mode_swizzler_;
   std::unique_ptr<ScopedBlockSwizzler> handle_startup_swizzler_;
   std::unique_ptr<ScopedBlockSwizzler> metrics_mediator_swizzler_;
   __block BOOL metrics_mediator_called_;
 };
 
 // TODO(crbug.com/585700): remove this.
 // Creates a requestTracker, needed for teardown.
 void createTracker(BOOL* created, base::Lock* lock) {
   web::RequestTrackerImpl::GetTrackerForRequestGroupID(@"test");
@@ skipping 168 matching lines @@
       [OCMockObject mockForProtocol:@protocol(BrowserLauncher)];
   [[[browserLauncher stub] andReturnValue:@(INITIALIZATION_STAGE_FOREGROUND)]
       browserInitializationStage];
   [[[browserLauncher stub] andReturn:browserViewInformation]
       browserViewInformation];
 
   id applicationDelegate =
       [OCMockObject mockForClass:[MainApplicationDelegate class]];
   id window = [OCMockObject mockForClass:[UIWindow class]];
 
-  base::scoped_nsobject<FakeStartupInformation> startupInformation(
-      [[FakeStartupInformation alloc] init]);
+  FakeStartupInformation* startupInformation =
+      [[FakeStartupInformation alloc] init];
   [startupInformation setIsColdStart:YES];
 
-  base::scoped_nsobject<AppState> appState([[AppState alloc]
-      initWithBrowserLauncher:browserLauncher
-           startupInformation:startupInformation
-          applicationDelegate:applicationDelegate]);
+  AppState* appState =
+      [[AppState alloc] initWithBrowserLauncher:browserLauncher
+                             startupInformation:startupInformation
+                            applicationDelegate:applicationDelegate];
   [appState setWindow:window];
 
   ASSERT_TRUE([startupInformation isColdStart]);
 
   // Action.
   [appState willResignActiveTabModel];
 
   // Test.
   EXPECT_FALSE([startupInformation isColdStart]);
   EXPECT_OCMOCK_VERIFY(tabModel);
@@ skipping 25 matching lines @@
       settingsNavigationController];
   [[appNavigation expect] closeSettingsAnimated:NO completion:nil];
 
   [[browserViewInformation expect] cleanDeviceSharingManager];
   [[browserViewInformation expect] haltAllTabs];
 
   id startupInformation =
       [OCMockObject mockForProtocol:@protocol(StartupInformation)];
   [[startupInformation expect] stopChromeMain];
 
-  base::scoped_nsobject<AppState> appState([[AppState alloc]
-      initWithBrowserLauncher:browserLauncher
-           startupInformation:startupInformation
-          applicationDelegate:applicationDelegate]);
+  AppState* appState =
+      [[AppState alloc] initWithBrowserLauncher:browserLauncher
+                             startupInformation:startupInformation
+                            applicationDelegate:applicationDelegate];
   [appState setWindow:window];
 
   id application = [OCMockObject mockForClass:[UIApplication class]];
   [[application expect] setMinimumBackgroundFetchInterval:
                             UIApplicationBackgroundFetchIntervalNever];
 
   // Action.
   [appState applicationWillTerminate:application
                applicationNavigation:appNavigation];
 
@@ skipping 34 matching lines @@
   id tabSwitcher = [OCMockObject mockForProtocol:@protocol(TabSwitching)];
 
   // BrowserViewInformation.
   id mainTabModel = [OCMockObject mockForClass:[TabModel class]];
   [[mainTabModel expect] resetSessionMetrics];
   [[[browserViewInformation stub] andReturn:mainTabModel] mainTabModel];
 
   // Swizzle Startup Parameters.
   swizzleHandleStartupParameters(tabOpener, browserViewInformation);
 
-  UIWindow* window = [[[UIWindow alloc] init] autorelease];
+  UIWindow* window = [[UIWindow alloc] init];
   AppState* appState = getAppStateWithOpenNTPAndIncognitoBlock(NO, window);
 
   ASSERT_EQ(NSUInteger(1), [window subviews].count);
 
   // Action.
   [appState resumeSessionWithTabOpener:tabOpener tabSwitcher:tabSwitcher];
 
   // Test.
   EXPECT_EQ(NSUInteger(0), [window subviews].count);
   EXPECT_OCMOCK_VERIFY(mainTabModel);
@@ skipping 21 matching lines @@
 
   // BrowserViewInformation.
   id mainTabModel = [OCMockObject mockForClass:[TabModel class]];
   [[mainTabModel expect] resetSessionMetrics];
   [[[browserViewInformation stub] andReturn:mainTabModel] mainTabModel];
 
   // TabSwitcher.
   id tabSwitcher = [OCMockObject mockForProtocol:@protocol(TabSwitching)];
   [[[tabSwitcher stub] andReturnValue:@YES] openNewTabFromTabSwitcher];
 
-  UIWindow* window = [[[UIWindow alloc] init] autorelease];
+  UIWindow* window = [[UIWindow alloc] init];
   AppState* appState = getAppStateWithOpenNTPAndIncognitoBlock(YES, window);
 
   ASSERT_EQ(NSUInteger(1), [window subviews].count);
 
   // Action.
   [appState resumeSessionWithTabOpener:tabOpener tabSwitcher:tabSwitcher];
 
   // Test.
   EXPECT_EQ(NSUInteger(0), [window subviews].count);
   EXPECT_OCMOCK_VERIFY(mainTabModel);
@@ skipping 26 matching lines @@
   [[currentBVC expect] newTab:nil];
   stubNullBrowserState(currentBVC);
 
   [[[browserViewInformation stub] andReturn:mainTabModel] mainTabModel];
   [[[browserViewInformation stub] andReturn:currentBVC] currentBVC];
 
   // TabSwitcher.
   id tabSwitcher = [OCMockObject mockForProtocol:@protocol(TabSwitching)];
   [[[tabSwitcher stub] andReturnValue:@NO] openNewTabFromTabSwitcher];
 
-  UIWindow* window = [[[UIWindow alloc] init] autorelease];
+  UIWindow* window = [[UIWindow alloc] init];
   AppState* appState = getAppStateWithOpenNTPAndIncognitoBlock(YES, window);
 
   // incognitoBlocker.
   ASSERT_EQ(NSUInteger(1), [window subviews].count);
 
   // Action.
   [appState resumeSessionWithTabOpener:tabOpener tabSwitcher:tabSwitcher];
 
   // Test.
   EXPECT_EQ(NSUInteger(0), [window subviews].count);
@@ skipping 127 matching lines @@
   id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]];
   id tabOpener = [OCMockObject mockForProtocol:@protocol(TabOpening)];
   id appNavigation = [OCMockObject mockForProtocol:@protocol(AppNavigation)];
 
   BrowserInitializationStageType stage = INITIALIZATION_STAGE_FOREGROUND;
   [[[getBrowserLauncherMock() stub] andReturnValue:@(stage)]
       browserInitializationStage];
 
   AppState* appState = getAppStateWithMock();
 
-  UIWindow* window = [[[UIWindow alloc] init] autorelease];
+  UIWindow* window = [[UIWindow alloc] init];
   appState.safeModeCoordinator =
-      [[[SafeModeCoordinator alloc] initWithWindow:window] autorelease];
+      [[SafeModeCoordinator alloc] initWithWindow:window];
 
   ASSERT_TRUE([appState isInSafeMode]);
 
   // Actions.
   [appState applicationWillEnterForeground:application
                            metricsMediator:metricsMediator
                               memoryHelper:memoryHelper
                                  tabOpener:tabOpener
                              appNavigation:appNavigation];
 }
 
 // Tests that -applicationDidEnterBackground creates an incognito blocker.
 TEST_F(AppStateTest, applicationDidEnterBackgroundIncognito) {
   // Setup.
-  UIWindow* window = [[[UIWindow alloc] init] autorelease];
+  UIWindow* window = [[UIWindow alloc] init];
   id application = [OCMockObject niceMockForClass:[UIApplication class]];
   id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]];
   id browserViewInformation = getBrowserViewInformationMock();
   id tabModel = [OCMockObject mockForClass:[TabModel class]];
   id startupInformation = getStartupInformationMock();
   id browserLauncher = getBrowserLauncherMock();
   BrowserInitializationStageType stage = INITIALIZATION_STAGE_FOREGROUND;
 
   AppState* appState = getAppStateWithRealWindow(window);
 
@@ skipping 19 matching lines @@
   // Tests.
   EXPECT_OCMOCK_VERIFY(startupInformation);
   EXPECT_TRUE(metricsMediatorHasBeenCalled());
   EXPECT_EQ(NSUInteger(1), [window subviews].count);
 }
 
 // Tests that -applicationDidEnterBackground do nothing if the application has
 // never been in a Foreground stage.
 TEST_F(AppStateTest, applicationDidEnterBackgroundStageBackground) {
   // Setup.
-  UIWindow* window = [[[UIWindow alloc] init] autorelease];
+  UIWindow* window = [[UIWindow alloc] init];
   id application = [OCMockObject mockForClass:[UIApplication class]];
   id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]];
   id browserLauncher = getBrowserLauncherMock();
   BrowserInitializationStageType stage = INITIALIZATION_STAGE_BACKGROUND;
 
   [[[browserLauncher stub] andReturnValue:@(stage)] browserInitializationStage];
 
   ASSERT_EQ(NSUInteger(0), [window subviews].count);
 
   // Action.
   [getAppStateWithRealWindow(window) applicationDidEnterBackground:application
                                                       memoryHelper:memoryHelper
                                                tabSwitcherIsActive:YES];
 
   // Tests.
   EXPECT_EQ(NSUInteger(0), [window subviews].count);
 }
 
 // Tests that -applicationDidEnterBackground does not create an incognito
 // blocker if there is no incognito tab.
 TEST_F(AppStateTest, applicationDidEnterBackgroundNoIncognitoBlocker) {
   // Setup.
-  UIWindow* window = [[[UIWindow alloc] init] autorelease];
+  UIWindow* window = [[UIWindow alloc] init];
   id application = [OCMockObject niceMockForClass:[UIApplication class]];
   id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]];
   id browserViewInformation = getBrowserViewInformationMock();
   id tabModel = [OCMockObject mockForClass:[TabModel class]];
   id startupInformation = getStartupInformationMock();
   id browserLauncher = getBrowserLauncherMock();
   BrowserInitializationStageType stage = INITIALIZATION_STAGE_FOREGROUND;
 
   AppState* appState = getAppStateWithRealWindow(window);
 
@@ skipping 14 matching lines @@
   // Action.
   [appState applicationDidEnterBackground:application
                              memoryHelper:memoryHelper
                       tabSwitcherIsActive:YES];
 
   // Tests.
   EXPECT_OCMOCK_VERIFY(startupInformation);
   EXPECT_TRUE(metricsMediatorHasBeenCalled());
   EXPECT_EQ(NSUInteger(0), [window subviews].count);
 }