[ObjC ARC] Converts ios/chrome/app/application_delegate:unit_tests to ARC.

ios/chrome/app/application_delegate/url_opener_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/app/application_delegate/url_opener.h"
 
 #import <Foundation/Foundation.h>
 
-#include "base/mac/scoped_nsobject.h"
 #include "ios/chrome/app/application_delegate/app_state.h"
 #include "ios/chrome/app/application_delegate/app_state_testing.h"
 #include "ios/chrome/app/application_delegate/mock_tab_opener.h"
 #include "ios/chrome/app/chrome_app_startup_parameters.h"
 #include "ios/chrome/app/main_application_delegate.h"
 #include "ios/chrome/app/main_controller.h"
 #include "ios/chrome/app/main_controller_private.h"
 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 #import "ios/chrome/test/base/scoped_block_swizzler.h"
 #import "ios/testing/ocmock_complex_type_helper.h"
 #import "net/base/mac/url_conversions.h"
 #include "testing/platform_test.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
 #include "third_party/ocmock/gtest_support.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 #pragma mark - Tab Switcher Mock
 
 // This mocks either a iPad tab switcher controller or a iPhone stack view
 // controller.
 @interface URLOpenerOCMockComplexTypeHandler : OCMockComplexTypeHelper
 @end
 
 @implementation URLOpenerOCMockComplexTypeHandler
 
 typedef Tab* (^mock_gurl_nsuinteger_pagetransition)(const GURL&,
@@ skipping 68 matching lines @@
 
 - (TabModel*)tabModel {
   return nil;
 }
 
 @end
 
 class URLOpenerTest : public PlatformTest {
  protected:
   MainController* GetMainController() {
-    if (!main_controller_.get()) {
-      main_controller_.reset([[MainController alloc] init]);
+    if (!main_controller_) {
+      main_controller_ = [[MainController alloc] init];
       [main_controller_ setUpAsForegrounded];
       id mainTabModel = [OCMockObject mockForClass:[TabModel class]];
       [[mainTabModel stub] resetSessionMetrics];
       [[mainTabModel stub] browserStateDestroyed];
       [[mainTabModel stub] addObserver:[OCMArg any]];
       [[mainTabModel stub] removeObserver:[OCMArg any]];
       [[main_controller_ browserViewInformation] setMainTabModel:mainTabModel];
     }
-    return main_controller_.get();
+    return main_controller_;
   }
 
  private:
-  base::scoped_nsobject<MainController> main_controller_;
+  MainController* main_controller_;
 };
 
 TEST_F(URLOpenerTest, HandleOpenURLWithNoOpenTab) {
   // The tab switcher controller should be dismissed with a new tab containing
   // the external URL.
   NSURL* url = [NSURL URLWithString:@"chromium://www.google.com"];
-  base::scoped_nsobject<ChromeAppStartupParameters> params(
+  ChromeAppStartupParameters* params =
       [ChromeAppStartupParameters newChromeAppStartupParametersWithURL:url
-                                                 fromSourceApplication:nil]);
+                                                 fromSourceApplication:nil];
 
-  base::scoped_nsobject<id> bvcMock([[URLOpenerMockBVC alloc] init]);
+  id bvcMock = [[URLOpenerMockBVC alloc] init];
 
-  base::scoped_nsobject<id> tabSwitcherController;
-  tabSwitcherController.reset([[URLOpenerOCMockComplexTypeHandler alloc]
+  id tabSwitcherController;
+  tabSwitcherController = [[URLOpenerOCMockComplexTypeHandler alloc]
       initWithRepresentedObject:[OCMockObject
-                                    mockForProtocol:@protocol(UrlLoader)]]);
+                                    mockForProtocol:@protocol(UrlLoader)]];
 
-  base::scoped_nsobject<id> block([(id) ^ (const GURL& url, NSUInteger position,
-                                           ui::PageTransition transition) {
+  id block = [(id) ^ (const GURL& url, NSUInteger position,
+                      ui::PageTransition transition) {
     EXPECT_EQ(url, [params externalURL]);
     EXPECT_EQ(NSNotFound, static_cast<NSInteger>(position));
     EXPECT_TRUE(PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_LINK));
-  } copy]);
+  } copy];
   SEL dismissSelector =
       @selector(dismissWithNewTabAnimationToModel:withURL:atIndex:transition:);
   [tabSwitcherController onSelector:dismissSelector callBlockExpectation:block];
 
   // Setup main controller.
   MainController* controller = GetMainController();
   controller.browserViewInformation.mainBVC = bvcMock;
   controller.tabSwitcherController = tabSwitcherController;
   controller.tabSwitcherActive = YES;
 
   id mainApplicationDelegate =
       [OCMockObject mockForClass:[MainApplicationDelegate class]];
 
   AppState* appState =
-      [[[AppState alloc] initWithBrowserLauncher:controller
-                              startupInformation:controller
-                             applicationDelegate:mainApplicationDelegate
-                                          window:controller.window
-                                   shouldOpenNTP:YES] autorelease];
+      [[AppState alloc] initWithBrowserLauncher:controller
+                             startupInformation:controller
+                            applicationDelegate:mainApplicationDelegate
+                                         window:controller.window
+                                  shouldOpenNTP:YES];
   controller.appState = appState;
 
   NSDictionary<NSString*, id>* options = nil;
   [URLOpener openURL:url
        applicationActive:YES
                  options:options
                tabOpener:controller
       startupInformation:controller];
 
   EXPECT_OCMOCK_VERIFY(tabSwitcherController);
 }
 
 TEST_F(URLOpenerTest, HandleOpenURLWithOpenTabs) {
   NSURL* url = [NSURL URLWithString:@"chromium://www.google.com"];
-  base::scoped_nsobject<URLOpenerMockBVC> bvc_mock(
-      [[URLOpenerMockBVC alloc] init]);
-  base::scoped_nsobject<URLOpenerMockBVC> otr_bvc_mock(
-      [[URLOpenerMockBVC alloc] init]);
+  URLOpenerMockBVC* bvc_mock = [[URLOpenerMockBVC alloc] init];
+  URLOpenerMockBVC* otr_bvc_mock = [[URLOpenerMockBVC alloc] init];
   TestChromeBrowserState::Builder main_browser_state_builder;
   std::unique_ptr<TestChromeBrowserState> chrome_browser_state =
       main_browser_state_builder.Build();
-  bvc_mock.get().browserState = chrome_browser_state.get();
+  bvc_mock.browserState = chrome_browser_state.get();
 
   // Setup main controller.
   MainController* controller = GetMainController();
   controller.browserViewInformation.mainBVC =
-      static_cast<BrowserViewController*>(bvc_mock.get());
+      static_cast<BrowserViewController*>(bvc_mock);
   controller.browserViewInformation.otrBVC =
-      static_cast<BrowserViewController*>(otr_bvc_mock.get());
+      static_cast<BrowserViewController*>(otr_bvc_mock);
 
   NSDictionary<NSString*, id>* options = nil;
   [URLOpener openURL:url
        applicationActive:YES
                  options:options
                tabOpener:controller
       startupInformation:controller];
 
   EXPECT_EQ(GURL("http://www.google.com/"), [bvc_mock tabURL]);
   EXPECT_EQ(NSNotFound, static_cast<NSInteger>([bvc_mock position]));
   EXPECT_TRUE(PageTransitionCoreTypeIs([bvc_mock transition],
                                        ui::PAGE_TRANSITION_LINK));
 
   EXPECT_FALSE([otr_bvc_mock tabURL].is_valid());
 }
 
 TEST_F(URLOpenerTest, HandleOpenURL) {
   // A set of tests for robustness of
   // application:openURL:options:tabOpener:startupInformation:
   // It verifies that the function handles correctly differents URL parsed by
   // ChromeAppStartupParameters.
   MainController* controller = GetMainController();
 
   // The array with the different states to tests (active, not active).
   NSArray* applicationStatesToTest = @[ @YES, @NO ];
 
   // Mock of TabOpening, preventing the creation of a new tab.
-  base::scoped_nsobject<MockTabOpener> tabOpener([[MockTabOpener alloc] init]);
+  MockTabOpener* tabOpener = [[MockTabOpener alloc] init];
 
   // The keys for this dictionary is the URL to call openURL:. The value
   // from the key is either YES or NO to indicate if this is a valid URL
   // or not.
   NSNumber* kIsValid = [NSNumber numberWithBool:YES];
   NSNumber* kNotValid = [NSNumber numberWithBool:NO];
   NSDictionary* urlsToTest = [NSDictionary
       dictionaryWithObjectsAndKeys:
           kNotValid, [NSNull null],
           // Tests for http, googlechrome, and chromium scheme URLs.
@@ skipping 35 matching lines @@
       for (id annotation in annotationsToTest) {
         for (NSNumber* applicationActive in applicationStatesToTest) {
           BOOL applicationIsActive = [applicationActive boolValue];
 
           controller.startupParameters = nil;
           [tabOpener resetURL];
           NSURL* testUrl = urlString == [NSNull null]
                                ? nil
                                : [NSURL URLWithString:urlString];
           BOOL isValid = [[urlsToTest objectForKey:urlString] boolValue];
-          base::scoped_nsobject<NSMutableDictionary> options(
-              [[NSMutableDictionary alloc] init]);
+          NSMutableDictionary* options = [[NSMutableDictionary alloc] init];
           if (source != [NSNull null]) {
             [options setObject:source
                         forKey:UIApplicationOpenURLOptionsSourceApplicationKey];
           }
           if (annotation != [NSNull null]) {
             [options setObject:annotation
                         forKey:UIApplicationOpenURLOptionsAnnotationKey];
           }
-          base::scoped_nsobject<ChromeAppStartupParameters> params(
-              [ChromeAppStartupParameters
-                  newChromeAppStartupParametersWithURL:testUrl
-                                 fromSourceApplication:nil]);
+          ChromeAppStartupParameters* params = [ChromeAppStartupParameters
+              newChromeAppStartupParametersWithURL:testUrl
+                             fromSourceApplication:nil];
 
           // Action.
           BOOL result = [URLOpener openURL:testUrl
                          applicationActive:applicationIsActive
                                    options:options
                                  tabOpener:tabOpener
                         startupInformation:controller];
 
           // Tests.
           EXPECT_EQ(isValid, result);
@@ skipping 167 matching lines @@
   [URLOpener handleLaunchOptions:launchOptions
                applicationActive:NO
                        tabOpener:tabOpenerMock
               startupInformation:startupInformationMock
                         appState:appStateMock];
 
   // Test.
   EXPECT_TRUE(hasBeenCalled);
   EXPECT_OCMOCK_VERIFY(startupInformationMock);
 }