Allow individual UI element properties to be modified.

Allow individual UI element properties to be modified.

This lets the UI vary a single element property, such as Z-position,
without having to re-state the other dimensions. In the future, this
will make it easier to also animate a single property.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2706343005
Cr-Commit-Position: refs/heads/master@{#452534}
Committed: https://chromium.googlesource.com/chromium/src/+/482d9496818eda5cf10c996256c0a5ea6d7380a5

[cjgrant, 2017-02-22 22:46:22]

Description was changed from

==========
Allow individual UI element properties to be modified.

This lets the UI vary a single element property, such as Z-position,
without having to re-state the other dimensions. In the future, this
will make it easier to also animate a single property.

BUG=None
==========

to

==========
Allow individual UI element properties to be modified.

This lets the UI vary a single element property, such as Z-position,
without having to re-state the other dimensions. In the future, this
will make it easier to also animate a single property.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2017-02-23 14:12:30]

cjgrant@chromium.org changed reviewers:
+ mthiesse@chromium.org, tiborg@chromium.org

[tiborg, 2017-02-23 15:21:19]

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:21: bool ParseInt(const
base::DictionaryValue& dict,
+1 for the templates!

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:24: return dict.GetInteger(key,
reinterpret_cast<int*>(output));
Is this safe when you use a different type than int for T, e.g. short?

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:410: ParseFloat(dict, "opacity",
&element->opacity);
Remove new lines or move the ParseFloat to the other parse floats?

[mthiesse, 2017-02-23 15:59:47]

lgtm

[cjgrant, 2017-02-23 16:13:37]

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:21: bool ParseInt(const
base::DictionaryValue& dict,
On 2017/02/23 15:21:18, tiborg wrote:
> +1 for the templates!

Acknowledged.

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:24: return dict.GetInteger(key,
reinterpret_cast<int*>(output));
On 2017/02/23 15:21:18, tiborg wrote:
> Is this safe when you use a different type than int for T, e.g. short?

Done. It was not, but it is now.

https://codereview.chromium.org/2706343005/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene.cc:410: ParseFloat(dict, "opacity",
&element->opacity);
On 2017/02/23 15:21:18, tiborg wrote:
> Remove new lines or move the ParseFloat to the other parse floats?

Done.

[tiborg, 2017-02-23 16:15:15]

lgtm

[cjgrant, 2017-02-23 16:16:04]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2017-02-23 16:16:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:25:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487866564316750,
"parent_rev": "419718939c4af924bcc43dea66656ec03419cb7d", "commit_rev":
"482d9496818eda5cf10c996256c0a5ea6d7380a5"}

[commit-bot: I haz the power, 2017-02-23 17:26:08]

Description was changed from

==========
Allow individual UI element properties to be modified.

This lets the UI vary a single element property, such as Z-position,
without having to re-state the other dimensions. In the future, this
will make it easier to also animate a single property.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow individual UI element properties to be modified.

This lets the UI vary a single element property, such as Z-position,
without having to re-state the other dimensions. In the future, this
will make it easier to also animate a single property.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2706343005
Cr-Commit-Position: refs/heads/master@{#452534}
Committed:
https://chromium.googlesource.com/chromium/src/+/482d9496818eda5cf10c996256c0...
==========

[commit-bot: I haz the power, 2017-02-23 17:26:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/482d9496818eda5cf10c996256c0...