Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2698033002: PROTOTYPE: Generic custom CSS property parsing (Closed)

Created:
3 years, 10 months ago by cjgrant
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PROTOTYPE: Generic custom CSS property parsing BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 14

Patch Set 2 : Rebase to ToT (native support is now in tip). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -44 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.css View 1 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 1 6 chunks +76 lines, -44 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
cjgrant
Folks, here's the CSS custom property parsing prototype. - I think it covers very basic ...
3 years, 10 months ago (2017-02-15 16:34:28 UTC) #3
tiborg
https://codereview.chromium.org/2698033002/diff/1/chrome/browser/android/vr_shell/ui_scene.cc File chrome/browser/android/vr_shell/ui_scene.cc (right): https://codereview.chromium.org/2698033002/diff/1/chrome/browser/android/vr_shell/ui_scene.cc#newcode459 chrome/browser/android/vr_shell/ui_scene.cc:459: ParseNumber(dict, "sizeX", &element->size.x); On 2017/02/15 16:34:27, cjgrant wrote: > ...
3 years, 10 months ago (2017-02-15 18:36:12 UTC) #4
cjgrant
3 years, 9 months ago (2017-03-03 15:11:07 UTC) #7
https://codereview.chromium.org/2698033002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2698033002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene.cc:459: ParseNumber(dict, "sizeX",
&element->size.x);
On 2017/02/15 18:36:11, tiborg wrote:
> On 2017/02/15 16:34:27, cjgrant wrote:
> > Independent of CSS custom properties, I'd like to clean up and submit this
> > change separately. I think it makes sense to allow tweaking of individual
> > properties.
> 
> +1, this is a good idea.

For the record, this change landed in ToT, and is rebased out of  this CL.

Powered by Google App Engine
This is Rietveld 408576698