Chrome VR clang-format cleanup

Chrome VR clang-format cleanup

- Apply clang-format to VR Shell, for fixes and consistency.
- Mirror VR Shell's PRESUBMIT.py in ui/webui.
- A couple of lint fixes in ui/webui.

BUG=None

Review-Url: https://codereview.chromium.org/2705293002
Cr-Commit-Position: refs/heads/master@{#452506}
Committed: https://chromium.googlesource.com/chromium/src/+/721affd3d363005352650612c5c146e6543925e2

[cjgrant, 2017-02-21 18:38:41]

https://codereview.chromium.org/2705293002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/easing.h (right):

https://codereview.chromium.org/2705293002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/easing.h:14: enum EasingType { LINEAR = 0,
CUBICBEZIER, EASEIN, EASEOUT };
Why is this happening?  The style guide doesn't appear to encourage putting more
than one enum element per line.

[cjgrant, 2017-02-21 18:41:07]

cjgrant@chromium.org changed reviewers:
+ thakis@chromium.org

[cjgrant, 2017-02-21 18:41:08]

thakis@, could you take a peek at the single comment I posted in this review? 
We want to apply clang-format to our part of the tree.  It's effects look fine
except for one thing.

[Nico, 2017-02-21 21:09:50]

See reply below.

However, I'd like to understand the motivation behind this change. Your code
seems to already follow chromium style. clang-format's rendering is just one
possible rendering of that style, and the formatting presubmit only checks lines
that have been touched, and `git cl format` also only reformats lines that have
been touched. So you get all the benefits of clang-format without having to
submit this CL.

What's more, clang-format's output isn't stable over time since its output gets
tweaked every now and then. So even if you land this: After the next
clang-format update your code will likely look different from clang-format's
post-update-output.

https://codereview.chromium.org/2705293002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/easing.h (right):

https://codereview.chromium.org/2705293002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/easing.h:14: enum EasingType { LINEAR = 0,
CUBICBEZIER, EASEIN, EASEOUT };
On 2017/02/21 18:38:41, cjgrant wrote:
> Why is this happening?  The style guide doesn't appear to encourage putting
more
> than one enum element per line.

if you want one line per element, put a trailing comma after the last element

[cjgrant, 2017-02-21 22:25:13]

On 2017/02/21 21:09:50, Nico wrote:
> See reply below.
> 
> However, I'd like to understand the motivation behind this change. Your code
> seems to already follow chromium style. clang-format's rendering is just one
> possible rendering of that style, and the formatting presubmit only checks
lines
> that have been touched, and `git cl format` also only reformats lines that
have
> been touched. So you get all the benefits of clang-format without having to
> submit this CL.
> 
> What's more, clang-format's output isn't stable over time since its output
gets
> tweaked every now and then. So even if you land this: After the next
> clang-format update your code will likely look different from clang-format's
> post-update-output.
> 
>
https://codereview.chromium.org/2705293002/diff/1/chrome/browser/android/vr_s...
> File chrome/browser/android/vr_shell/easing.h (right):
> 
>
https://codereview.chromium.org/2705293002/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/easing.h:14: enum EasingType { LINEAR = 0,
> CUBICBEZIER, EASEIN, EASEOUT };
> On 2017/02/21 18:38:41, cjgrant wrote:
> > Why is this happening?  The style guide doesn't appear to encourage putting
> more
> > than one enum element per line.
> 
> if you want one line per element, put a trailing comma after the last element

Thanks!  The motivation is simply to fix some divergence from the spec that has
crept in, such that any future auto-formatting doesn't generate unexpected
diffs.  If you're saying the formatted output changes over time, that's not a
big deal - this really is a one-off.

Even though the CL format checks look at deltas only, it would be really nice to
be able to auto-format a whole file, and not see a pile of extraneous changes.

Thanks for the heads up on the enum-comma detail!

[cjgrant, 2017-02-22 16:29:48]

Description was changed from

==========
Chrome VR codebase clang-format trial run.

This CL shows what'll happen to our code if we hammer it with
clang-format.

BUG=None
==========

to

==========
Chrome VR clang-format cleanup

- Apply clang-format to VR Shell, for fixes and consistency.
- Mirror VR Shell's PRESUBMIT.py in ui/webui.
- A couple of lint fixes in ui/webui.

BUG=None
==========

[cjgrant, 2017-02-22 16:29:48]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, mthiesse@chromium.org

[bshe, 2017-02-23 14:12:21]

vr_shell lgtm

[cjgrant, 2017-02-23 14:21:05]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2017-02-23 14:21:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 14:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 14:23:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[cjgrant, 2017-02-23 15:26:00]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-02-23 15:26:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2705293002/#ps40001
(title: "Rebase to ToT.")

[commit-bot: I haz the power, 2017-02-23 15:26:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 16:05:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487863560257140,
"parent_rev": "1292fd1de885beaaa353f8d200b62199a625754f", "commit_rev":
"721affd3d363005352650612c5c146e6543925e2"}

[commit-bot: I haz the power, 2017-02-23 16:05:51]

Description was changed from

==========
Chrome VR clang-format cleanup

- Apply clang-format to VR Shell, for fixes and consistency.
- Mirror VR Shell's PRESUBMIT.py in ui/webui.
- A couple of lint fixes in ui/webui.

BUG=None
==========

to

==========
Chrome VR clang-format cleanup

- Apply clang-format to VR Shell, for fixes and consistency.
- Mirror VR Shell's PRESUBMIT.py in ui/webui.
- A couple of lint fixes in ui/webui.

BUG=None

Review-Url: https://codereview.chromium.org/2705293002
Cr-Commit-Position: refs/heads/master@{#452506}
Committed:
https://chromium.googlesource.com/chromium/src/+/721affd3d363005352650612c5c1...
==========

[commit-bot: I haz the power, 2017-02-23 16:05:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/721affd3d363005352650612c5c1...