MD-Settings: Adds an a11y label to most toggle buttons.

MD-Settings: Adds an a11y label to most toggle buttons.

The only missing toggle button is for the network summary item. That
toggle is non-trivial to label, so it'll be labelled in its own CL.

BUG=693370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2705543003
Cr-Commit-Position: refs/heads/master@{#452357}
Committed: https://chromium.googlesource.com/chromium/src/+/505735cda080442c7d251abc0dcf4601d7b041a7

[hcarmona, 2017-02-17 19:12:28]

Description was changed from

==========
MD-Settings: Adds an a11y label to most toggle buttons.

The only missing toggle button is for the network summary item. That
toggle is non-trivial to label, so it'll be labelled in its own CL.

BUG=693370
==========

to

==========
MD-Settings: Adds an a11y label to most toggle buttons.

The only missing toggle button is for the network summary item. That
toggle is non-trivial to label, so it'll be labelled in its own CL.

BUG=693370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2017-02-17 19:12:30]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:13:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2017-02-17 21:54:43]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[hcarmona, 2017-02-17 21:54:59]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-17 21:55:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2017-02-17 21:55:39]

hcarmona@chromium.org changed reviewers:
+ dschuyler@chromium.org

[hcarmona, 2017-02-17 21:55:40]

PTAL

[Dan Beam, 2017-02-17 22:06:46]

https://codereview.chromium.org/2705543003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_toggle_button.html
(right):

https://codereview.chromium.org/2705543003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_toggle_button.html:52:
on-change="notifyChangedByUserInteraction" aria-labelledby="label"
yeah, this is the big one

[commit-bot: I haz the power, 2017-02-17 23:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:58:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[dschuyler, 2017-02-22 23:43:33]

https://codereview.chromium.org/2705543003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2705543003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:214:
aria-label$="[[item.language.displayName]]">
aria-label$= is used here, while aria-label= is used elsewhere in this CL.
Do they need to be different?

[Dan Beam, 2017-02-23 00:00:38]

https://codereview.chromium.org/2705543003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2705543003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.html:214:
aria-label$="[[item.language.displayName]]">
On 2017/02/22 23:43:33, dschuyler wrote:
> aria-label$= is used here, while aria-label= is used elsewhere in this CL.
> Do they need to be different?

yes

[dschuyler, 2017-02-23 00:15:52]

lgtm

[hcarmona, 2017-02-23 01:05:42]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 01:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2017-02-23 01:08:05]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2017-02-23 01:08:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2705543003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-23 01:08:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 02:44:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487812085636210,
"parent_rev": "ade6fdf493bec82b248ad76bc1d378f5d3ea99e4", "commit_rev":
"505735cda080442c7d251abc0dcf4601d7b041a7"}

[commit-bot: I haz the power, 2017-02-23 02:44:56]

Description was changed from

==========
MD-Settings: Adds an a11y label to most toggle buttons.

The only missing toggle button is for the network summary item. That
toggle is non-trivial to label, so it'll be labelled in its own CL.

BUG=693370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD-Settings: Adds an a11y label to most toggle buttons.

The only missing toggle button is for the network summary item. That
toggle is non-trivial to label, so it'll be labelled in its own CL.

BUG=693370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2705543003
Cr-Commit-Position: refs/heads/master@{#452357}
Committed:
https://chromium.googlesource.com/chromium/src/+/505735cda080442c7d251abc0dcf...
==========

[commit-bot: I haz the power, 2017-02-23 02:44:57]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/505735cda080442c7d251abc0dcf...