Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/action_link_css.html"> 2 <link rel="import" href="chrome://resources/html/action_link_css.html">
3 <link rel="import" href="chrome://resources/html/assert.html"> 3 <link rel="import" href="chrome://resources/html/assert.html">
4 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
5 <link rel="import" href="chrome://resources/html/polymer.html"> 5 <link rel="import" href="chrome://resources/html/polymer.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]"> 203 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]">
204 <div class="list-frame vertical-list"> 204 <div class="list-frame vertical-list">
205 <template is="dom-repeat" items="[[languages.enabled]]"> 205 <template is="dom-repeat" items="[[languages.enabled]]">
206 <div class="list-item"> 206 <div class="list-item">
207 <div class="start" on-tap="onSpellCheckChange_" 207 <div class="start" on-tap="onSpellCheckChange_"
208 actionable$="[[item.language.supportsSpellcheck]]"> 208 actionable$="[[item.language.supportsSpellcheck]]">
209 [[item.language.displayName]] 209 [[item.language.displayName]]
210 </div> 210 </div>
211 <paper-toggle-button on-change="onSpellCheckChange_" 211 <paper-toggle-button on-change="onSpellCheckChange_"
212 disabled="[[!item.language.supportsSpellcheck]]" 212 disabled="[[!item.language.supportsSpellcheck]]"
213 checked="[[item.spellCheckEnabled]]"> 213 checked="[[item.spellCheckEnabled]]"
214 aria-label$="[[item.language.displayName]]">
dschuyler 2017/02/22 23:43:33 aria-label$= is used here, while aria-label= is us
Dan Beam 2017/02/23 00:00:38 yes
214 </paper-toggle-button> 215 </paper-toggle-button>
215 </div> 216 </div>
216 </template> 217 </template>
217 <div class="list-item"> 218 <div class="list-item">
218 <a is="action-link" class="list-button" 219 <a is="action-link" class="list-button"
219 on-tap="onEditDictionaryTap_"> 220 on-tap="onEditDictionaryTap_">
220 $i18n{manageSpellCheck} 221 $i18n{manageSpellCheck}
221 </a> 222 </a>
222 </div> 223 </div>
223 </div> 224 </div>
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 </if> 294 </if>
294 </settings-animated-pages> 295 </settings-animated-pages>
295 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 296 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
296 <settings-add-languages-dialog languages="{{languages}}" 297 <settings-add-languages-dialog languages="{{languages}}"
297 language-helper="[[languageHelper]]"> 298 language-helper="[[languageHelper]]">
298 </settings-add-languages-dialog> 299 </settings-add-languages-dialog>
299 </template> 300 </template>
300 </template> 301 </template>
301 <script src="languages_page.js"></script> 302 <script src="languages_page.js"></script>
302 </dom-module> 303 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698