Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: chrome/browser/resources/settings/controls/settings_toggle_button.html

Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">
3 <link rel="import" href="settings_boolean_control_behavior.html"> 3 <link rel="import" href="settings_boolean_control_behavior.html">
4 <link rel="import" href="../settings_shared_css.html"> 4 <link rel="import" href="../settings_shared_css.html">
5 5
6 <dom-module id="settings-toggle-button"> 6 <dom-module id="settings-toggle-button">
7 <template> 7 <template>
8 <style include="settings-shared"> 8 <style include="settings-shared">
9 :host([elide-label]), 9 :host([elide-label]),
10 :host([elide-label]) #outerRow, 10 :host([elide-label]) #outerRow,
(...skipping 21 matching lines...) Expand all
32 -webkit-margin-start: var(--checkbox-spacing); 32 -webkit-margin-start: var(--checkbox-spacing);
33 } 33 }
34 34
35 ::content .more-actions { 35 ::content .more-actions {
36 -webkit-margin-end: 10px; 36 -webkit-margin-end: 10px;
37 } 37 }
38 </style> 38 </style>
39 <div id="outerRow" noSubLabel$="[[!subLabel]]"> 39 <div id="outerRow" noSubLabel$="[[!subLabel]]">
40 <div class="flex" on-tap="onLabelWrapperTap_" 40 <div class="flex" on-tap="onLabelWrapperTap_"
41 actionable$="[[!controlDisabled_(disabled, pref)]]"> 41 actionable$="[[!controlDisabled_(disabled, pref)]]">
42 <div class="label"> 42 <div id="label" class="label">
43 [[label]] 43 [[label]]
44 </div> 44 </div>
45 <div class="secondary label">[[subLabel]]</div> 45 <div class="secondary label">[[subLabel]]</div>
46 </div> 46 </div>
47 <content select=".more-actions"></content> 47 <content select=".more-actions"></content>
48 <template is="dom-if" if="[[pref.controlledBy]]" restamp> 48 <template is="dom-if" if="[[pref.controlledBy]]" restamp>
49 <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator> 49 <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>
50 </template> 50 </template>
51 <paper-toggle-button id="control" checked="{{checked}}" 51 <paper-toggle-button id="control" checked="{{checked}}"
52 on-change="notifyChangedByUserInteraction" 52 on-change="notifyChangedByUserInteraction" aria-labelledby="label"
Dan Beam 2017/02/17 22:06:46 yeah, this is the big one
53 disabled="[[controlDisabled_(disabled, pref)]]"> 53 disabled="[[controlDisabled_(disabled, pref)]]">
54 </paper-toggle-button> 54 </paper-toggle-button>
55 </div> 55 </div>
56 </template> 56 </template>
57 <script src="settings_toggle_button.js"></script> 57 <script src="settings_toggle_button.js"></script>
58 </dom-module> 58 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698