chrome/browser/resources/settings/internet_page/network_siminfo.html - Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_siminfo.html

Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_proxy.html ('k') | chrome/browser/resources/settings/languages_page/languages_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_siminfo.html

diff --git a/chrome/browser/resources/settings/internet_page/network_siminfo.html b/chrome/browser/resources/settings/internet_page/network_siminfo.html

index b6de3eea194bad5790ff686e8ff5bd84cbc34d26..250ae0a00a32673ef4ae416370dd1df6cb0bec32 100644

--- a/chrome/browser/resources/settings/internet_page/network_siminfo.html

+++ b/chrome/browser/resources/settings/internet_page/network_siminfo.html

@@ -76,13 +76,16 @@

<div class="settings-box two-line"

hidden$="[[!showSimUnlocked_(networkProperties)]]">

- <div class="start">$i18n{networkSimLockEnable}</div>

+ <div id="simLockToggleLabel" class="start">

+ $i18n{networkSimLockEnable}

+ </div>

<paper-button on-tap="onChangePinTap_"

hidden$="[[!networkProperties.Cellular.SIMLockStatus.LockEnabled]]">

$i18n{networkSimChangePin}

</paper-button>

<paper-toggle-button on-change="onSimLockEnabledChange_"

- checked="[[networkProperties.Cellular.SIMLockStatus.LockEnabled]]">

+ checked="[[networkProperties.Cellular.SIMLockStatus.LockEnabled]]"

+ aria-labelledby="simLockToggleLabel">

</paper-toggle-button>

</div>