Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout

Expand FrameSeleciton::isCaret()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isCaret()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isCaret()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2704123003
Cr-Commit-Position: refs/heads/master@{#451744}
Committed: https://chromium.googlesource.com/chromium/src/+/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b

[yosin_UTC9, 2017-02-21 03:52:12]

Description was changed from

==========
2017-02-21T12:50:46

2017-02-21T12:50:37

BUG=
==========

to

==========
Expand FrameSeleciton::isCaret()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isCaret()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isCaret()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 03:52:16]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 03:52:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 06:35:07]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-21 06:35:08]

PTAL

Changes in core/editing/ core/input/ and web/

[tkent, 2017-02-21 06:40:47]

lgtm

[yosin_UTC9, 2017-02-21 06:44:13]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-21 06:44:17]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 06:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 06:48:34]

Description was changed from

==========
Expand FrameSeleciton::isCaret()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isCaret()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isCaret()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::isCaret()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isCaret()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isCaret()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-02-21 08:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 08:23:18]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2017-02-21 12:29:18]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 12:29:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 13:01:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487680158555530, "parent_rev":
"d4cacfa2ec6d6f41385b40f46af7ab385aba0921", "commit_rev":
"c183eaa3876b03b16c2c84e3dfb3b87b63071a5b"}

[commit-bot: I haz the power, 2017-02-21 13:07:23]

Description was changed from

==========
Expand FrameSeleciton::isCaret()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isCaret()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isCaret()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::isCaret()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isCaret()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isCaret()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base()
- extent()
- start()
- end()
- isNone()
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2704123003
Cr-Commit-Position: refs/heads/master@{#451744}
Committed:
https://chromium.googlesource.com/chromium/src/+/c183eaa3876b03b16c2c84e3dfb3...
==========

[commit-bot: I haz the power, 2017-02-21 13:07:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c183eaa3876b03b16c2c84e3dfb3...