third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 2704123003: Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2704123003: Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T12:50:46 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index 7587722432c4d74d6a6b3aefb67630bd90c3e756..d8269f7e129bd1f6795522e8566165ee9494ebc3 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -415,7 +415,7 @@ static bool hasChildTags(Element& element, const QualifiedName& tagName) {

static TriState selectionListState(const FrameSelection& selection,

const QualifiedName& tagName) {

- if (selection.isCaret()) {

+ if (selection.computeVisibleSelectionInDOMTreeDeprecated().isCaret()) {

if (enclosingElementWithTag(

selection.computeVisibleSelectionInDOMTreeDeprecated().start(),

tagName))